Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Rename --source-feed to --add-source #9164

Merged
merged 2 commits into from
May 1, 2018
Merged

Rename --source-feed to --add-source #9164

merged 2 commits into from
May 1, 2018

Conversation

@wli3
Copy link

@wli3 wli3 commented Apr 27, 2018 •
edited
Loading

@wli3 wli3 force-pushed the rename-to-add-source branch from 9120085 to d51926a Compare April 27, 2018 18:24
@KathleenDollard
Copy link

KathleenDollard commented Apr 27, 2018

LGTM

@wli3 wli3 changed the title WIP Rename to add source Rename to add source Apr 27, 2018
@wli3 wli3 requested review from a team and peterhuene April 27, 2018 19:28
@wli3
Copy link
Author

wli3 commented Apr 27, 2018

preparing shiproom email

peterhuene
peterhuene reviewed Apr 27, 2018
View reviewed changes
src/dotnet/commands/dotnet-tool/install/LocalizableStrings.resx Outdated
<data name="SourceFeedOptionName" xml:space="preserve">
<value>SOURCE_FEED</value>
<data name="AddSourceOptionName" xml:space="preserve">
<value>ADD_SOURCE</value>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

peterhuene
peterhuene suggested changes Apr 27, 2018
View reviewed changes
Copy link

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use SOURCE instead of ADD_SOURCE for the option name; it gives a cleaner command line help.

@wli3 wli3 force-pushed the rename-to-add-source branch from 4a80192 to 33aa705 Compare April 27, 2018 21:10
@wli3 wli3 changed the title Rename to add source Rename --source-feed to --add-source Apr 27, 2018
@MattGertz
Copy link

MattGertz commented Apr 27, 2018

I agree; current verbiage is confusing.

@livarcocc
Copy link

livarcocc commented Apr 30, 2018

@dotnet-bot Test CentOS7.1 x64 Debug Build

@livarcocc livarcocc added this to the 2.1.3xx milestone Apr 30, 2018
@livarcocc
Copy link

livarcocc commented Apr 30, 2018

Marking WIP until the branches are open for RTM changes.

@livarcocc livarcocc changed the title Rename --source-feed to --add-source WIP: Rename --source-feed to --add-source Apr 30, 2018
@livarcocc livarcocc changed the title WIP: Rename --source-feed to --add-source Rename --source-feed to --add-source Apr 30, 2018
@livarcocc
Copy link

livarcocc commented Apr 30, 2018

@dotnet-bot Test CentOS7.1 x64 Debug Build

@wli3 wli3 merged commit d681933 into dotnet:release/2.1.3xx May 1, 2018
@wli3 wli3 deleted the rename-to-add-source branch May 1, 2018 17:21
@ghost ghost mentioned this pull request May 2, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@peterhuene peterhuene peterhuene approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge

Projects

None yet

Milestone

2.1.3xx

Development

Successfully merging this pull request may close these issues.

5 participants

@wli3 @KathleenDollard @MattGertz @livarcocc @peterhuene