-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembly descriptions take up a lot of space #1800
Comments
In spite of our workaround in runtime repo (using |
Related: dotnet/msbuild#8720 suggesting a warning about overlong AssemblyDescriptionAttribute or Win32 version resource. Place the long description in command-line-api/src/System.CommandLine/System.CommandLine.csproj Lines 10 to 16 in 87704ce
Besides, "Constructor- and property-based model binding for complex types" in that description seems out of date, as that feature is now in a separate package. Line 9 in 87704ce
|
The description of System.CommandLine was shortened in #2224, although one wouldn't guess from the summary of that PR.
|
In an app with a System.CommandLine reference, the following text:
is repeated 28 times, taking up 14+ kB.
The text is embedded in the Win32 resource (UTF-16) and within a custom attribute reference (UTF-8) in each of the System.CommandLine assemblies (the main assembly itself, and 13 satellites assemblies.
My suggestion would be to replace this with a simple "System.CommandLine" string, same as libraries produced in the dotnet/runtime repo do.
The text was updated successfully, but these errors were encountered: