Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming ThrowIfInvalid to clarify the intent #1908

Open
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 1 comment
Open
Tracked by #1891

Consider renaming ThrowIfInvalid to clarify the intent #1908

jonsequitur opened this issue Nov 2, 2022 · 1 comment
Assignees
@adamsitnik
Labels
Area-API needs discussion Further discussion required
Milestone
2.0 GA

Comments

@jonsequitur
Copy link
Contributor

No description provided.

@jonsequitur jonsequitur mentioned this issue Nov 2, 2022
Open
56 tasks
@jonsequitur jonsequitur added Area-API needs discussion Further discussion required labels Nov 2, 2022
@adamsitnik adamsitnik self-assigned this Nov 4, 2022
adamsitnik added a commit to adamsitnik/command-line-api that referenced this issue Nov 4, 2022
@adamsitnik
rename ThrowIfInvalid to Validate, fixes dotnet#1908
6cd2235
@adamsitnik adamsitnik mentioned this issue Nov 4, 2022
Closed
@jonsequitur jonsequitur added this to the 2.0 GA milestone Nov 9, 2022
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Nov 24, 2022
Open
@KalleOlaviNiemitalo
Copy link

The ThrowIfInvalid name is similar to that of CancellationToken.ThrowIfCancellationRequested.

Validate could be confused with validators that can be added to commands, arguments, and options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsitnik adamsitnik

Labels
Area-API needs discussion Further discussion required
Projects
None yet
Milestone
2.0 GA
Development

Successfully merging a pull request may close this issue.

Rename ThrowIfInvalid to Validate, change thrown exception adamsitnik/command-line-api
3 participants
@jonsequitur @adamsitnik @KalleOlaviNiemitalo