some renaming in help APIs #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
help-api-updates
branch
from
139243c to
d81b13c
Compare
jonsequitur
force-pushed
the
help-api-updates
branch
from
d81b13c to
df39bac
Compare
jonsequitur
force-pushed
the
help-api-updates
branch
from
df39bac to
24615d0
Compare
vlada-shubina
approved these changes
Nov 11, 2021
Member
vlada-shubina
left a comment
vlada-shubina
left a comment
There was a problem hiding this comment.
thanks for keeping me informed, looks good.
Not sure if descriptor/description rename makes it better, however just a personal taste.
| /// Initializes a new instance of the CommandLineConfiguration class. | ||
| /// </summary> | ||
| /// <param name="command">The symbol to parse.</param> | ||
| /// <param name="command">The root command for the parser.</param> |
Member
There was a problem hiding this comment.
just a question: should it be always root command? or can it be also subcommand? (if subcommand is reparsed)?
Contributor
Author
There was a problem hiding this comment.
It can be either RootCommand or Command. You can build a parser just for subtree of your command hierarchy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.