Skip to content

Removes the custom GetHashCode and Equals overrides in HelpOption and VerboseOption #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

jonsequitur
Copy link
Contributor

@jonsequitur jonsequitur commented Apr 10, 2023

This fixes #2118.

It also fixed #2116.

This removes the custom GetHashCode and Equals overrides in HelpOption and VerboseOption.
@jonsequitur jonsequitur merged commit 723cd2c into dotnet:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do HelpOption and VersionOption need to override Equals and GetHashCode? Internal property HelpBuilder.OnCustomize is always null
1 participant