Remove Store user profile #2539
Conversation
ramarag
force-pushed
the
store_user_profile
branch
from
6875432
to
0075919
Compare
| @@ -117,14 +106,16 @@ The host will probe in the following order of precedence for `dotnet run` and ap | |||
|
|
|||
| + `$CORE_SERVICING` on Unix or `%ProgramFiles(x86)%\coreservicing` on Windows. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| + The global shared package store | ||
| + The Shared Framework directory | ||
| + ~~`DOTNET_HOSTING_OPTIMIZATION_CACHE` deprecated in favor of `DOTNET_SHARED_STORE`~~ | ||
| + `--additionalprobingpaths` specified in the command line | ||
| + `runtimeOptions.additionalProbingPaths` (includes NuGet cache probe specified by the CLI for `dotnet run`) | ||
| + Application `bin` directory | ||
|
|
||
| **NOTE:** `--additionalprobingpaths` can be passed template paths like below and the host will interpret `{arch}/{tfm}` appropriately to look for assets: | ||
| `%USERPROFILE%\.dotnet\store\{arch}\{tfm}` or `$HOME/.dotnet/store/{arch}/{tfm}` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if (pal::realpath(&real)) | ||
| pal::string_t probe_path = path; | ||
|
|
||
| if (pal::realpath(&probe_path) && pal::directory_exists(probe_path)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -255,5 +286,18 @@ private void MoveRuntimeConfigToSubdirectory(TestProjectFixture testProjectFixtu | |||
|
|
|||
| testProjectFixture.TestProject.RuntimeConfigJson = destRuntimeConfig; | |||
| } | |||
|
|
|||
| private string CreateAStrore(TestProjectFixture testProjectFixture) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| dotnet = dotnet ?? _sdkDotnet; | ||
| outputDirectory = outputDirectory ?? _testProject.OutputDirectory; | ||
|
|
||
| var publishArgs = new List<string>(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| .Should() | ||
| .Pass() | ||
| .And | ||
| .HaveStdOutContaining("Hello World"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ramarag
force-pushed
the
store_user_profile
branch
from
0075919
to
5291b4c
Compare
|
@gkhanna79 @eerhardt i have address all the concerns above |
src/corehost/cli/fxr/fx_muxer.cpp
Outdated
| { | ||
| realpaths->push_back(real); | ||
| //Check if we can extrapolate {arch}<DIR_SEPARATOR>{tfm} for probing stores |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| .And | ||
| .HaveStdOutContaining("Hello World") | ||
| .And | ||
| .HaveStdErrContaining($"Adding tpa entry: {store_path}"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ramarag
force-pushed
the
store_user_profile
branch
from
5291b4c
to
e3847d3
Compare
ramarag
force-pushed
the
store_user_profile
branch
from
e3847d3
to
7c58389
Compare
fixes https://github.com/dotnet/core-setup/issues/2533
@eerhardt @gkhanna79 PTAL