This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] HostWriter: Remove signature on MAC host #8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to conform with Catalina notarization requirements, the template apphost will be shipped after codesigning. This commit implements a change to remove the code-signature when customizing the apphost for an app. Testing: - Tested the HostModel library using a locally signed version of apphost - Verified that unsigned host can be re-signed later - Verified that the original unsigned-apphost, and the signature-removed-apphost are binary equal. TODO: * SDK changes for consuming the AppHostMachOFormatException * Port the change to 3.1, backport to earlier versions * For .net 5, factor out PE specific code in BinaryUtils into a separate file (similar to MacOUtil).
Clear the signature command manually, instead of using Unsafe.InitBlock since this API is not available before .net Core 3.0
lpereira
approved these changes
Oct 18, 2019
nguerrera
approved these changes
Oct 18, 2019
|
approved for 3.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostWriter: Remove signature on MAC host
Tracking Issue
Fixes https://github.com/dotnet/core-setup/issues/8589
Customer Scenario
In order to conform with Catalina notarization requirements, the template apphost will be shipped after codesigning.
When the template apphost is customized for a specific app, the signature is no longer valid.
This commit implements the change to remove the signature from the apphost when customized for a specific app by the SDK using the HostModel library.
Master Branch
Commit: 3d36990
PR: #8543