Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Changes to prepare for consolidation #8593

Merged
merged 10 commits into from
Oct 18, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the root directory of the repository configurable in corehost/bu…
…ild.cmd and corehost/build.sh.
jkoritzinsky committed Oct 18, 2019
commit 8fc792de14917b3640b58d45ad4bddfdfbb28cdf
15 changes: 10 additions & 5 deletions src/corehost/build.cmd
Original file line number Diff line number Diff line change
@@ -4,9 +4,6 @@ setlocal
:SetupArgs
:: Initialize the args that will be passed to cmake
set __nativeWindowsDir=%~dp0Windows
set __binDir=%~dp0..\..\artifacts\bin
set __objDir=%~dp0..\..\artifacts\obj
set __rootDir=%~dp0..\..
set __CMakeBinDir=""
set __IntermediatesDir=""
set __BuildArch=x64
@@ -40,6 +37,7 @@ if /i [%1] == [policyver] (set __HostPolicyVersion=%2&&shift&&shift&goto Arg_L
if /i [%1] == [commit] (set __CommitSha=%2&&shift&&shift&goto Arg_Loop)

if /i [%1] == [incremental-native-build] ( set __IncrementalNativeBuild=1&&shift&goto Arg_Loop)
if /i [%1] == [rootDir] ( set __rootDir=%2&&shift&&shift&goto Arg_Loop)

shift
goto :Arg_Loop
@@ -87,6 +85,15 @@ set __VSVersion=15 2017
call "%VS150COMNTOOLS%..\..\VC\Auxiliary\Build\vcvarsall.bat" %__VCBuildArch%

:SetupDirs

if %__rootDir% == "" (
echo Root directory must be provided via the rootDir parameter.
exit /b 1
)

set __binDir=%__rootDir%\artifacts\bin
set __objDir=%__rootDir%\artifacts\obj

:: Setup to cmake the native components
echo Commencing build of corehost
echo.
@@ -137,8 +144,6 @@ goto :Failure
:: Build the project created by Cmake
set __msbuildArgs=/p:Platform=%__BuildArch% /p:PlatformToolset="%__PlatformToolset%"

cd %__rootDir%

SET __NativeBuildArgs=/t:rebuild
if /i "%__IncrementalNativeBuild%" == "1" SET __NativeBuildArgs=

2 changes: 2 additions & 0 deletions src/corehost/build.proj
Original file line number Diff line number Diff line change
@@ -31,6 +31,7 @@
<BuildArgs Condition="'$(PortableBuild)' == 'true'">$(BuildArgs) -portable</BuildArgs>
<BuildArgs Condition="'$(CrossBuild)' == 'true'">$(BuildArgs) --cross</BuildArgs>
<BuildArgs Condition="'$(StripSymbols)' == 'true'">$(BuildArgs) --stripsymbols</BuildArgs>
<BuildArgs>$(BuildArgs) --rootdir $(RepoRoot)</BuildArgs>
</PropertyGroup>

<!--
@@ -85,6 +86,7 @@
<BuildArgs>$(ConfigurationGroup) $(TargetArchitecture) apphostver $(AppHostVersion) hostver $(HostVersion) fxrver $(HostResolverVersion) policyver $(HostPolicyVersion) commit $(LatestCommit) rid $(OutputRid)</BuildArgs>
<BuildArgs Condition="'$(PortableBuild)' == 'true'">$(BuildArgs) portable</BuildArgs>
<BuildArgs Condition="'$(IncrementalNativeBuild)' == 'true'">$(BuildArgs) incremental-native-build</BuildArgs>
<BuildArgs>$(BuildArgs) rootdir $(RepoRoot)</BuildArgs>
</PropertyGroup>

<!--
24 changes: 17 additions & 7 deletions src/corehost/build.sh
Original file line number Diff line number Diff line change
@@ -58,9 +58,10 @@ init_rid_plat()

usage()
{
echo "Usage: $0 --configuration <configuration> --arch <Architecture> --hostver <Dotnet exe version> --apphostver <app host exe version> --fxrver <HostFxr library version> --policyver <HostPolicy library version> --commithash <Git commit hash> [--xcompiler <Cross C++ Compiler>]"
echo "Usage: $0 --rootdir <path> --configuration <configuration> --arch <Architecture> --hostver <Dotnet exe version> --apphostver <app host exe version> --fxrver <HostFxr library version> --policyver <HostPolicy library version> --commithash <Git commit hash> [--xcompiler <Cross C++ Compiler>]"
echo ""
echo "Options:"
echo " --rootdir <path> Path to the root of the repository. Required."
echo " --configuration <configuration> Build configuration (Debug, Release)"
echo " --arch <Architecture> Target Architecture (x64, x86, arm, arm64, armel)"
echo " --hostver <Dotnet host version> Version of the dotnet executable"
@@ -85,9 +86,6 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symli
[[ "$SOURCE" != /* ]] && SOURCE="$DIR/$SOURCE" # if $SOURCE was a relative symlink, we need to resolve it relative to the path where the symlink file was located
done
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
RootRepo="$DIR/../.."

__bin_dir="$RootRepo/artifacts/bin"
__build_arch=
__host_ver=
__apphost_ver=
@@ -99,8 +97,6 @@ __portableBuildArgs=
__configuration=Debug
__linkPortable=0
__cmake_defines=
__baseIntermediateOutputPath="$RootRepo/artifacts/obj"
__versionSourceFile="$__baseIntermediateOutputPath/_version.c"
__cmake_bin_prefix=

while [ "$1" != "" ]; do
@@ -148,12 +144,26 @@ while [ "$1" != "" ]; do
--stripsymbols)
__cmake_defines="${__cmake_defines} -DSTRIP_SYMBOLS=true"
;;
--rootdir)
shift
RootRepo=$1
;;
*)
echo "Unknown argument to build.sh $1"; usage; exit 1
esac
shift
done

if [ "$RootRepo" == "" ]; then
usage
fi

SetupRoot="$RootRepo/src/setup"

__bin_dir="$RootRepo/artifacts/bin"
__baseIntermediateOutputPath="$RootRepo/artifacts/obj"
__versionSourceFile="$__baseIntermediateOutputPath/_version.c"

__cmake_defines="${__cmake_defines} -DCMAKE_BUILD_TYPE=${__configuration} ${__portableBuildArgs}"

mkdir -p "$__baseIntermediateOutputPath"
@@ -180,7 +190,7 @@ __cmake_defines="${__cmake_defines} ${__arch_define}"
# Configure environment if we are doing a cross compile.
if [ "$__CrossBuild" == 1 ]; then
if ! [[ -n $ROOTFS_DIR ]]; then
export ROOTFS_DIR="$RootRepo/cross/rootfs/$__build_arch"
export ROOTFS_DIR="$SetupRoot/cross/rootfs/$__build_arch"
fi
fi