update branding to 3.1.2 #8945
update branding to 3.1.2 #8945
Conversation
Anipik
added
the
* NO MERGE *
| <PreReleaseVersionLabel>servicing</PreReleaseVersionLabel> | ||
| <!-- Enable to remove prerelease label. --> | ||
| <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">true</StabilizePackageVersion> | ||
| <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> |
There was a problem hiding this comment.
This may cause pain downstream if merged because dotnet/runtime#639 is not fixed yet. /cc @nguerrera @wtgodbe
I believe the fix is pretty simple, just change <ItemGroup Condition="'$(StabilizePackageVersion)' == 'true'"> to <ItemGroup> below. Since this branch won't enter "master-branch mode" ever again, I believe this is fine. I only should need to find something better in dotnet/runtime.
Could you give it a try in this PR? We should be able to confirm the packages don't get created via the PR validation logs.
There was a problem hiding this comment.
We should not make this false in the PR, btw.
There was a problem hiding this comment.
yes this was opened before ur email. I have edited this in all other open prs
|
closing this one as branding change needs to happen with other changes |
No description provided.