Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown formatting #9369

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Update markdown formatting #9369

merged 6 commits into from
Jun 26, 2024

Conversation

richlander
Copy link
Member

No description provided.

@Falco20019
Copy link
Contributor

Falco20019 commented Jun 26, 2024

There is a strange artifact in https://raw.githubusercontent.com/dotnet/core/8a0d0c9577d9f6d864411e85b16e54d390eacc83/release-notes/7.0/supported-os.md

image

Looks a bit like the file was shorter and wrote into an existing older variant. We might want to ensure it's truncated on opening in the generator.

@jamesmontemagno
Copy link
Member

@richlander let me know if those linux links are okay

https://developer.android.com/about/versions/pie is legit so we are fine to merge if the other updates I did are good

@richlander
Copy link
Member Author

I am going to make a couple more changes.

@richlander richlander merged commit 18130e5 into main Jun 26, 2024
2 of 4 checks passed
@richlander richlander deleted the fix-md-formatting branch June 26, 2024 20:35
@Falco20019
Copy link
Contributor

Falco20019 commented Jun 26, 2024

@richlander Shouldn‘t the links in the JSON be changed as well? As this is where those originated from.
For example:

"link": "https://developer.apple.com/ios/",

@richlander
Copy link
Member Author

Can you elaborate? I'm not following.

@richlander
Copy link
Member Author

I understand now. I missed that @jamesmontemagno changed the markdown. I'll fix that in another one PR. Thanks for noticed that.

@Falco20019
Copy link
Contributor

Yes, it seems that you reverted his changes by regenerating. He seemed to have fixed some links. And the Linux support would need to be fixed in the templates before regenerating.

@richlander
Copy link
Member Author

The Apple links don't seem better to me. They don't relate to an OS version. What was your thinking on that @jamesmontemagno ?

@richlander
Copy link
Member Author

#9371

@jamesmontemagno
Copy link
Member

The Apple links don't seem better to me. They don't relate to an OS version. What was your thinking on that @jamesmontemagno ?

https://support.apple.com/ios/ goes to a random article on how to install it
https://support.apple.com/ipados doesn't exist

trying to align with the other ones for macos and apple-tv... there isn't a lifecycle though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants