-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-specific release.json files #9427
Conversation
Co-authored-by: Martin Costello <martin@martincostello.com>
I think I got all of that @martincostello. Thanks much! The formats file still needs some help. I'll make another PR to update the link forwards in |
I believe that this PR is ready to go. Much of this is based on an OM I built, which is the basis of the schema generation and the serializer for We need to wait for @leecow to validate the following changes:
These all need to be uploaded/updated in blob storage before merging. We should also double check that everyone is good with the new property and file names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See some comments on richlander/distroessed#5 (review) for changes to the generated schemas. Usually, schemas also do set "additionalProperties": false
to make it clear that there are no additional fields allowed in the JSON. Not fully required, but would make intention more clear.
release-notes/releases-index.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the $schema
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if System.Text.Json supports those things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default STJ allows additional properties which is reflected in the generated schema. This setting can be overridden using the JsonUnmappedMemberHandlingAttribute
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this update.
Removed semicolon after property declaration
* os-packages.json: Add FreeBSD section * Change order of OS families * Update markdown --------- Co-authored-by: Gleb Popov <6yearold@gmail.com>
I had to do process a merge conflict due to #9424. I knew that would happen, but that's how it goes. |
This work will be broken into multiple PRs. |
Fixes #9417.
Improvements:
releases-index.json
patch-releases-index.json
, per releaserelease.json
, per patch releasereleases.json
, per major release, to include all the required information for generating the other files$schema
reference to JSON filesNotes:
os-packages.json
files for .NET 6 and 8 in a later PR.@Falco20019 @martincostello @leecow