API diff between .NET 9 Preview 6 and .NET 9 Preview 7 #9450

carlossanlop · 2024-08-13T18:00:17Z

Repo area owners:

ASP.NET - @dotnet/aspnet-api-review
WinForms - @merriemcgaw @lonitra @JeremyKuhne
WPF - @singhashish-wpf and @pchaurasia14
Libraries - @artl93 @jeffschwMSFT @jeffhandley @karelz @ericstj @stephentoub @SamMonoRT

Libraries area owners:

System @dotnet/area-system-runtime
System.Data @SamMonoRT @ajcvickers @DavoudEshtehari @David-Engel @roji
System.Diagnostics @dotnet/area-system-diagnostics @dotnet/area-system-diagnostics-metric
System.Formats.Tar @dotnet/area-system-formats-tar
System.Net @dotnet/ncl
System.Numerics @dotnet/area-system-numerics
System.Runtime.InteropServices @dotnet/interop-contrib
System.Runtime.Intrinsics @dotnet/area-system-runtime-intrinsics
System.Security @dotnet/area-system-security
System.Text.Json @dotnet/area-system-text-json
System.Threading @mangod9 @kouvel

Known api-diff tool issues:

If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:

The AsmDiff tool sometimes skips adding { or {} arcade#10981([AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API arcade#13814)
RequiresPreviewAttribute not getting auto added arcade#14498
Changes to protected internal visibility should stop showing. AsmDiff: Do not show APIs with protected internal visibility arcade#14579
The AsmDiff tool shows APIs with decorating attribute changes as removed and re-added, instead of showing only the API. Please ignore this, it might be confusing but technically it's not incorrect: [arcade#13814]

carlossanlop · 2024-08-13T18:03:58Z

...notes/9.0/preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Formats.Tar.md

+``` diff
+ namespace System.Formats.Tar {
+     public abstract class TarEntry {
+        public long DataOffset { get; }


System.Formats.Tar LGTM but I cannot sign-off my own PR.

tannergooding · 2024-08-13T18:08:44Z

...se-notes/9.0/preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Numerics.md

@@ -0,0 +1,150 @@
+# System.Numerics


System.Numerics LGTM

CC. @dotnet/area-system-numerics

tannergooding · 2024-08-13T18:09:09Z

...review/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Runtime.Intrinsics.Arm.md

@@ -0,0 +1,477 @@
+# System.Runtime.Intrinsics.Arm


System.Runtime.Intrinsics.Arm LGTM

CC. @dotnet/area-system-runtime-intrinsics, @dotnet/arm64-contrib

tannergooding · 2024-08-13T18:13:36Z

....0/preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Runtime.Intrinsics.md

@@ -0,0 +1,159 @@
+# System.Runtime.Intrinsics


System.Runtime.Intrinsics LGTM

CC. @dotnet/area-system-runtime-intrinsics

tannergooding · 2024-08-13T18:14:02Z

release-notes/9.0/preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.md

@@ -0,0 +1,54 @@
+# System


System LGTM

CC. @dotnet/area-system-runtime

cc. @dotnet/area-system-datetime for the TimeSpan changes

tannergooding

My areas LGTM

eiriktsarpalis

STJ changes LGTM

David-Engel · 2024-08-13T20:15:06Z

release-notes/9.0/preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Data.md

+``` diff
+ namespace System.Data {
+     public enum SqlDbType {
+        Json = 35,


@saurabh500 for the JSON changes

Lgtm for SqlDbType

roji

OK for the System.Data changes

tarekgh · 2024-08-13T20:34:40Z

System.Diagnostics.Metrics
System.Environment
System.TimeSpan

LGTM

kouvel · 2024-08-13T22:47:16Z

System.Threading LGTM

bartonjs · 2024-08-13T22:51:00Z

...preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Security.Cryptography.md

+ namespace System.Security.Cryptography {
+-    [UnsupportedOSPlatformAttribute("browser")]
+-    [UnsupportedOSPlatformAttribute("ios")]
+-    [UnsupportedOSPlatformAttribute("tvos")]
+-    public sealed class AesGcm : IDisposable
+    [SupportedOSPlatformAttribute("ios13.0")]
+    [SupportedOSPlatformAttribute("maccatalyst")]
+    [SupportedOSPlatformAttribute("tvos13.0")]
+    [UnsupportedOSPlatformAttribute("browser")]
+    [UnsupportedOSPlatformAttribute("ios")]
+    [UnsupportedOSPlatformAttribute("tvos")]
+    public sealed class AesGcm : IDisposable


The diff is weird... lines 5-7 and 12-14 are "remove this, and put it back", so could be eliminated. Line 8/15 is just "context", not "diff". But doesn't really matter.

bartonjs

System.Security LGTM, modulo some inefficient diffs.

rzikm · 2024-08-14T11:04:48Z

...se-notes/9.0/preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Net.Http.md

+``` diff
+ namespace System.Net.Http {
+     public abstract class HttpContent : IDisposable {
+        public Task LoadIntoBufferAsync(long maxBufferSize, CancellationToken cancellationToken);
+        public Task LoadIntoBufferAsync(CancellationToken cancellationToken);
+     }
+     [UnsupportedOSPlatformAttribute("browser")]
+     public sealed class SocketsHttpHandler : HttpMessageHandler {
+        public bool EnableMultipleHttp3Connections { get; set; }
+     }
+ }
+```


System.Net.* LGTM

...preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Security.Cryptography.md

carlossanlop added 4 commits August 13, 2024 10:47

Microsoft.AspNetCore.App

fa63629

Microsoft.NETCore.App

41689bf

Microsoft.WindowsDesktop.App

9ecbcef

README.md

925a3ad

carlossanlop self-assigned this Aug 13, 2024

carlossanlop requested review from rbhanda and leecow as code owners August 13, 2024 18:00

carlossanlop commented Aug 13, 2024

View reviewed changes

tannergooding reviewed Aug 13, 2024

View reviewed changes

tannergooding approved these changes Aug 13, 2024

View reviewed changes

eiriktsarpalis approved these changes Aug 13, 2024

View reviewed changes

David-Engel reviewed Aug 13, 2024

View reviewed changes

roji approved these changes Aug 13, 2024

View reviewed changes

bartonjs reviewed Aug 13, 2024

View reviewed changes

bartonjs approved these changes Aug 13, 2024

View reviewed changes

rzikm reviewed Aug 14, 2024

View reviewed changes

carlossanlop commented Aug 15, 2024

View reviewed changes

...preview/preview7/api-diff/Microsoft.NETCore.App/9.0-preview7_System.Security.Cryptography.md Outdated Show resolved Hide resolved

Apply suggestions from code review

d076cfb

carlossanlop merged commit b0aa77e into dotnet:main Aug 15, 2024
3 checks passed

carlossanlop deleted the ApiDiffPrev7 branch August 15, 2024 02:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API diff between .NET 9 Preview 6 and .NET 9 Preview 7 #9450

API diff between .NET 9 Preview 6 and .NET 9 Preview 7 #9450

carlossanlop commented Aug 13, 2024 •

edited

Loading

carlossanlop Aug 13, 2024

tannergooding Aug 13, 2024

tannergooding Aug 13, 2024

tannergooding Aug 13, 2024

tannergooding Aug 13, 2024

tannergooding Aug 13, 2024

tannergooding left a comment

eiriktsarpalis left a comment

David-Engel Aug 13, 2024

saurabh500 Aug 13, 2024

roji Aug 13, 2024

roji left a comment

tarekgh commented Aug 13, 2024

kouvel commented Aug 13, 2024

bartonjs Aug 13, 2024

bartonjs left a comment

rzikm Aug 14, 2024

API diff between .NET 9 Preview 6 and .NET 9 Preview 7 #9450

API diff between .NET 9 Preview 6 and .NET 9 Preview 7 #9450

Conversation

carlossanlop commented Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tannergooding left a comment

Choose a reason for hiding this comment

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roji left a comment

Choose a reason for hiding this comment

tarekgh commented Aug 13, 2024

kouvel commented Aug 13, 2024

Choose a reason for hiding this comment

bartonjs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlossanlop commented Aug 13, 2024 •

edited

Loading