Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Commit

Permalink
Fix watson bucketing/broken triage dumps (#26670)
Browse files Browse the repository at this point in the history
Fix watson bucketing/broken triage dumps

The DAC EnumMemoryRegions needs to include some missing code version
manager memory.
  • Loading branch information
mikem8361 authored Sep 12, 2019
1 parent b0fa2f8 commit 922429d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/vm/method.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5475,6 +5475,11 @@ MethodDesc::EnumMemoryRegions(CLRDataEnumMemoryFlags flags)
}
}

#ifdef FEATURE_CODE_VERSIONING
// Make sure the active IL and native code version are in triage dumps.
GetCodeVersionManager()->GetActiveILCodeVersion(dac_cast<PTR_MethodDesc>(this)).GetActiveNativeCodeVersion(dac_cast<PTR_MethodDesc>(this));
#endif

// Also, call DacValidateMD to dump the memory it needs. !clrstack calls
// DacValidateMD before it retrieves the method name. We don't expect
// DacValidateMD to fail, but if it does, ignore the failure and try to assemble the
Expand Down

0 comments on commit 922429d

Please sign in to comment.