Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Local GC] Combine related threading GCToEEInterface callbacks #8275

Closed
swgillespie opened this issue Jun 1, 2017 · 1 comment
Closed

[Local GC] Combine related threading GCToEEInterface callbacks #8275

swgillespie opened this issue Jun 1, 2017 · 1 comment
Assignees
@swgillespie
Labels
area-GC-coreclr
Milestone
2.1.0

Comments

@swgillespie
Copy link
Contributor

See dotnet/coreclr#12036 (comment) for details. The fact that IsPreemptiveGCDisabled, Enable/DisablePreemptiveGC, GetAllocContext, and CatchAtSafePoint each take a Thread parameter instead of operating on the current thread ensures that callers will incur the cost of at least two indirections: once to call GetThread and once again to call the function unsing the thread.

If each one of the above functions operates on the current thread, it can avoid an indirection in the GC by directly calling GetThread.
@swgillespie swgillespie self-assigned this Jun 1, 2017
@jkotas
Copy link
Member

jkotas commented Mar 23, 2018

Fixed by dotnet/coreclr#16765

@jkotas jkotas closed this as completed Mar 23, 2018
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
MichalStrehovsky pushed a commit to MichalStrehovsky/runtime that referenced this issue Oct 12, 2020
@jkotas
Fix alignment of marshaled inline arrays (dotnet#8275)
3b19f83 
Fixes dotnet#8274
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swgillespie swgillespie

Labels
area-GC-coreclr
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@swgillespie @jkotas @msftgits