This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[Local GC] Forbid inclusion of gcscan.h from VM and DAC directories #10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
x86 job failed with https://github.com/dotnet/coreclr/issues/10022 @dotnet-bot test Windows_NT x86 Checked Build and Test |
jkotas
reviewed
Mar 21, 2017
src/vm/object.cpp
Outdated
| @@ -1776,9 +1775,10 @@ VOID Object::ValidateInner(BOOL bDeep, BOOL bVerifyNextHeader, BOOL bVerifySyncB | |||
| // try to validate next object's header | |||
| if (bDeep | |||
| && bVerifyNextHeader | |||
| && GCScan::GetGcRuntimeStructuresValid () | |||
| && GCHeapUtilities::IsGCHeapInitialized() | |||
There was a problem hiding this comment.
IsGCHeapInitialized call does not look necessary - if we have an object to validate, it sure must have come from GCHeap and thus the GCHeap is initialized.
jkotas
approved these changes
Mar 21, 2017
Maoni0
approved these changes
Mar 21, 2017
…assert, since the heap should definitely be initialized if we are validating objects that ostensibly came from it
|
@dotnet-bot test Linux ARM Emulator Cross Debug Build |
|
thanks! |
jorive
pushed a commit
to guhuro/coreclr
that referenced
this pull request
May 4, 2017
…otnet#10332) * Forbid inclusion of gcscan.h from VM and DAC directories * Address code review feedback - hoist IsGCHeapInitialized check to an assert, since the heap should definitely be initialized if we are validating objects that ostensibly came from it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the inclusion of
gcscan.hfrom three places in the VM and once place in the DAC. For the VM uses,IGCHeap::RuntimeStructuresValidwas added so that the VM can ask the GC whether structures are in valid state (previously done throughGCScan::GetGcRuntimeStructuresValid). For the DAC use, the DAC variable thatGCScan::GetGcRuntimeStructuresValidreads is referenced directly (gc_structures_invalid_cnt).