Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Use 4-byte align for double in struct #10340

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

parjong
Copy link

@parjong parjong commented Mar 21, 2017

This commit revises default struct layout in order to fix #10133.

This commit introduces 4 failures for x86/Linux, but it turns out that all of these tests depend on the existing struct layout rule, and thus invalid for x86/Linux:

  • Interop.MarshalAPI.OffsetOf.OffsetOf.OffsetOf
  • JIT.Directed.RVAInit.nested.nested
  • JIT.Directed.RVAInit.simple.simple
  • JIT.Regression.CLR-x86-JIT.V1.2-Beta1.b103058.b103058.b103058

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit be9896c into dotnet:master Mar 21, 2017
@parjong parjong deleted the fix/x86_4byte_double_align branch March 21, 2017 04:49
jorive pushed a commit to guhuro/coreclr that referenced this pull request May 4, 2017
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[x86/Linux] JIT.Methodical.structs.systemvbringup.structinregs test failure
4 participants