-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add subfolders to Documentation folder #1114
Conversation
Hi @blackdwarf, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
@blackdwarf, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
LGTM, thanks for doing this work 👍 Can we integrate the content of dotnetcore-intro.md into README.md as well? It's just a single paragraph so I don't think it warrants a separate file at the root. |
LGTM |
@akoeplinger Agreed. @richlander are you ok with this suggestion? |
Thanks for doing this @blackdwarf. Few comments.
I'd prefer to following directories:
Basically, I'd prefer not to use gerunds. |
Looks like you should rebase master on your change. I merged in an update earlier tonight. Not surprisingly not compatible with a rename PR. |
OK, fixed the folder name as per @richlander suggestion, However, I cannot rename building to build, since build/ is in .gitignore. Don't want to mess with that at this point, so I suggest we just leave it as is, unless someone can educate me on the best way to do this. :) |
@blackdwarf good point! Please ignore my aesthetics on that issue. It is not worth futzing with .gitignore to make it work. |
As raised in #1075 by @akoeplinger, the Documentation folder's file list forces the user to scroll way down to see the README.md. This PR fixes that by storing the documents in separate sub-folders one per hierarchy of related documents. Also changed Documentation\README.md and root README.md to take into account the new paths.
657bc73
to
09ad260
Compare
Add subfolders to Documentation folder
As raised in #1075 by @akoeplinger, the Documentation folder's file
list forces the user to scroll way down to see the README.md. This
PR fixes that by storing the documents in separate sub-folders one
per hierarchy of related documents. Also changed
Documentation\README.md and root README.md to take into account
the new paths.
/cc @richlander @akoeplinger @terrajobst @kangaroo