This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[Local GC] No longer need to initialize SVR dacvars separately #12173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swgillespie
force-pushed
the
local-gc-svrdacvars
branch
from
a87a73e
to
a1e1afa
Compare
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test |
adityamandaleeka
approved these changes
Jun 9, 2017
|
@noahfalk @mikem8361 PTAL? this should all be dead code. |
|
thanks for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all server dacvars go through the
GcDacVarsstruct (#9255 - despite the name this also includes Server GC), we don't need to initialize them here. Furthermore, since there are noDEFINE_DACVAR_SVRmacros indacvars.hanymore, this function has no effect anyway today.