Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Throw PlatformNotSupported for named sync primitives on Unix #1387

Merged
merged 1 commit into from
Aug 14, 2015

Conversation

stephentoub
Copy link
Member

libcoreclr's synchronization primitives implementation currently supports names, but those names have process-wide rather than system-wide scope. This is very dangerous for most code that would want names, as they're typically used for cross-process synchronization, and as such the current behavior could lead to bad race conditions difficult to diagnose. Until a better solution is available, we will throw PlatformNotSupportedException when trying to create such named primitives.

libcoreclr's synchronization primitives implementation currently supports names, but those names have process-wide rather than system-wide scope.  This is very dangerous for most code that would want names, as they're typically used for cross-process synchronization, and as such the current behavior could lead to bad race conditions difficult to diagnose.  Until a better solution is available, we will throw PlatformNotSupportedException when trying to create such named primitives.
@stephentoub
Copy link
Member Author

Corresponding PR in corefx: dotnet/corefx#2796

@stephentoub
Copy link
Member Author

cc: @kouvel, @jkotas, @ellismg

@jkotas
Copy link
Member

jkotas commented Aug 14, 2015

LGTM

jkotas added a commit that referenced this pull request Aug 14, 2015
Throw PlatformNotSupported for named sync primitives on Unix
@jkotas jkotas merged commit ed73a1c into dotnet:master Aug 14, 2015
@stephentoub stephentoub deleted the named_primitives branch August 14, 2015 02:07
stephentoub added a commit to stephentoub/corefx that referenced this pull request Aug 14, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
stephentoub added a commit to stephentoub/corefx that referenced this pull request Aug 15, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
rajansingh10 pushed a commit to rajansingh10/corefx that referenced this pull request Aug 20, 2015
rajansingh10 pushed a commit to rajansingh10/corefx that referenced this pull request Aug 20, 2015
rajansingh10 pushed a commit to rajansingh10/corefx that referenced this pull request Oct 16, 2015
rajansingh10 pushed a commit to rajansingh10/corefx that referenced this pull request Oct 18, 2015
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
With dotnet/coreclr#1387 merged, these can now be enabled.


Commit migrated from dotnet/corefx@04bb308
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants