This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Throw PlatformNotSupported for named sync primitives on Unix #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libcoreclr's synchronization primitives implementation currently supports names, but those names have process-wide rather than system-wide scope. This is very dangerous for most code that would want names, as they're typically used for cross-process synchronization, and as such the current behavior could lead to bad race conditions difficult to diagnose. Until a better solution is available, we will throw PlatformNotSupportedException when trying to create such named primitives.
Corresponding PR in corefx: dotnet/corefx#2796 |
LGTM |
jkotas
added a commit
that referenced
this pull request
Aug 14, 2015
Throw PlatformNotSupported for named sync primitives on Unix
stephentoub
added a commit
to stephentoub/corefx
that referenced
this pull request
Aug 14, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
stephentoub
added a commit
to stephentoub/corefx
that referenced
this pull request
Aug 15, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
rajansingh10
pushed a commit
to rajansingh10/corefx
that referenced
this pull request
Aug 20, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
rajansingh10
pushed a commit
to rajansingh10/corefx
that referenced
this pull request
Aug 20, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
rajansingh10
pushed a commit
to rajansingh10/corefx
that referenced
this pull request
Oct 16, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
rajansingh10
pushed a commit
to rajansingh10/corefx
that referenced
this pull request
Oct 18, 2015
With dotnet/coreclr#1387 merged, these can now be enabled.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
With dotnet/coreclr#1387 merged, these can now be enabled. Commit migrated from dotnet/corefx@04bb308
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcoreclr's synchronization primitives implementation currently supports names, but those names have process-wide rather than system-wide scope. This is very dangerous for most code that would want names, as they're typically used for cross-process synchronization, and as such the current behavior could lead to bad race conditions difficult to diagnose. Until a better solution is available, we will throw PlatformNotSupportedException when trying to create such named primitives.