This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix for #12609 - add option to disable tiered compilation for profilers #14643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfalk
reviewed
Oct 21, 2017
src/pal/prebuilt/inc/corprof.h
Outdated
| @@ -514,6 +514,7 @@ enum __MIDL___MIDL_itf_corprof_0000_0000_0006 | |||
| COR_PRF_HIGH_ADD_ASSEMBLY_REFERENCES = 0x1, | |||
| COR_PRF_HIGH_IN_MEMORY_SYMBOLS_UPDATED = 0x2, | |||
| COR_PRF_HIGH_MONITOR_DYNAMIC_FUNCTION_UNLOADS = 0x4, | |||
| COR_PRF_HIGH_DISABLE_TIERED_COMPILATION = 0x8, | |||
| COR_PRF_HIGH_REQUIRE_PROFILE_IMAGE = 0, | |||
| COR_PRF_HIGH_ALLOWABLE_AFTER_ATTACH = ( COR_PRF_HIGH_IN_MEMORY_SYMBOLS_UPDATED | COR_PRF_HIGH_MONITOR_DYNAMIC_FUNCTION_UNLOADS ) , | |||
| COR_PRF_HIGH_MONITOR_IMMUTABLE = 0 | |||
There was a problem hiding this comment.
The new flag should be immutable because a method's eligibility for tiered compilation is also immutable. It doesn't look like COR_PRF_HIGH_MONITOR_IMMUTABLE is correctly hooked up, but you can copy what COR_PRF_MONITOR_IMMUTABLE does. The basic premise is that the flag can only be set at startup, and if you do then the profiler has permanently altered the default runtime configuration and isn't allowed to detach.
There was a problem hiding this comment.
I updated to mimic what COR_PRF_MONITOR_IMMUTABLE does. I can't test the profiler detach path since we don't have profiler attach, but I at least verified that if you call SetEventMask2 and try to change the state it will return E_FAIL and abort
|
LGTM |
noahfalk
approved these changes
Oct 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12609