Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Enable EventPipe and EventSource Functional Tests #15917

Merged
merged 3 commits into from
Jan 18, 2018

Conversation

brianrob
Copy link
Member

No description provided.

@brianrob brianrob requested a review from nategraf January 18, 2018 19:43
@nategraf
Copy link

nategraf commented Jan 18, 2018

The tests called EventSource* should stay disabled on Windows until EventPipe supports events from EventSource. the test called EventSourceTrace will fail on Linux due to microsoft/perfview#461

In order to change which tests run based on OS, the changes are related to runtests.proj (but I can't remember the exact file). Disabling them in tests/src/dirs.proj prevents them from building and therefore will not run on any platform.

@brianrob
Copy link
Member Author

Thanks @nategraf. I have updated issues.targets which allows us to be fairly fine-grained about where the tests are disabled. The CI run will confirm that this works in the CI and I'm validating this locally as well.

@brianrob
Copy link
Member Author

@nategraf, this passed my local runs Windows, Linux and OSX. Do you have any concerns or is this ready for merge?

Copy link

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ran and passed. Looks good 👍

@brianrob brianrob merged commit 25d6ccb into dotnet:master Jan 18, 2018
@brianrob brianrob deleted the enable_eventpipe_tests branch January 18, 2018 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants