-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Converting more of the x86 HWIntrinsic tests to be generated from a template #16115
Conversation
The following Sse tests still need to be converted:
|
Fixed a bug where |
…s to use a template.
Rebased to resolve a merge conflict. |
test Windows_NT x64 Checked jitincompletehwintrinsic test Windows_NT x86 Checked jitincompletehwintrinsic test Ubuntu x64 Checked jitincompletehwintrinsic |
Ubuntu failures are unrelated: #16134 |
This should be ready for review. |
Thanks for the work, I will take a look by end of today. |
public void RunLclFldScenario() | ||
{{ | ||
var test = new BooleanComparisonOpTest__{1}{2}(); | ||
var result = {0}.{1}(test._fld1, test._fld2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. Looks like we need another template for Avx comparisons that take two vectors and an imm value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we will end up having at least 5-10 templates to support all tests, but this is much more manageable than 500-1000 individual tests that need handling 😉
I think it is even fine if the templates are "nearly" identical in some cases, as they are still few in number and it makes the overall logic to maintain them simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI. @CarolEidt, @fiigii