This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix GC reproting for by-ref-like structs #16231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouvel
force-pushed
the
SpanFix
branch
3 times, most recently
from
4992787 to
3e0dc5a
Compare
Fixes https://github.com/dotnet/coreclr/issues/16044: - Divide by pointer size was removed to produce the proper offset - Fixed some assertion failures seen in https://github.com/dotnet/coreclr/issues/16229
jkotas
reviewed
Feb 6, 2018
src/vm/object.inl
Outdated
| @@ -389,7 +389,7 @@ inline void FindByRefPointerOffsetsInByRefLikeObject(PTR_MethodTable pMT, SIZE_T | |||
| continue; | |||
| } | |||
|
|
|||
| SIZE_T fieldStartIndex = pFD->GetOffset() / sizeof(void *); | |||
| SIZE_T fieldStartIndex = pFD->GetOffset(); | |||
There was a problem hiding this comment.
Nit: This is offset not index.
It can be just used directly on next line without being stored into a local field:
FindByRefPointerOffsetsInByRefLikeObject(pFieldMT, baseOffset + pFD->GetFieldOffset(), processPointerOffset);
jkotas
approved these changes
Feb 6, 2018
kouvel
added a commit
to kouvel/coreclr
that referenced
this pull request
Feb 10, 2018
Port of a portion of dotnet#16231 to release/2.1. Fixes https://github.com/dotnet/coreclr/issues/16044: - Divide by pointer size was removed to produce the proper offset
jkotas
pushed a commit
that referenced
this pull request
Feb 10, 2018
Port of a portion of #16231 to release/2.1. Fixes https://github.com/dotnet/coreclr/issues/16044: - Divide by pointer size was removed to produce the proper offset
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix GC reproting for by-ref-like structs Fixes https://github.com/dotnet/coreclr/issues/16044: - Divide by pointer size was removed to produce the proper offset - Fixed some assertion failures seen in https://github.com/dotnet/coreclr/issues/16229 Commit migrated from dotnet/coreclr@e15f90f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/coreclr/issues/16044: