This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix path issues #16554
Merged
Fix path issues #16554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path tests weren't running so a few issues sneaked in.
danmoseley
reviewed
Feb 25, 2018
| bool extendedUncSyntax = StartsWithOrdinal(path, UncExtendedPathPrefix); | ||
| if (extendedSyntax) | ||
| bool deviceSyntax = IsDevice(path); | ||
| bool deviceUnc = deviceSyntax && IsDeviceUNC(path); |
There was a problem hiding this comment.
Note that IsDeviceUNC also calls IsDevice itself.
There was a problem hiding this comment.
You coudl take off deviceSyntax &&
There was a problem hiding this comment.
Yes, that was intentional. Skipping the method call for a bool check.
danmoseley
approved these changes
Feb 25, 2018
|
@dotnet-bot test Tizen armel Cross Checked Innerloop Build and Test |
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 25, 2018
Path tests weren't running so a few issues sneaked in. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 25, 2018
Path tests weren't running so a few issues sneaked in. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 25, 2018
Path tests weren't running so a few issues sneaked in. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 26, 2018
Path tests weren't running so a few issues sneaked in. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
kbaladurin
pushed a commit
to kbaladurin/corert
that referenced
this pull request
Mar 15, 2018
Path tests weren't running so a few issues sneaked in. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path tests weren't running so a few issues sneaked in. (https://github.com/dotnet/corefx/issues/27426) I have a large test change that I'm finishing validating that works around the test infrastructure issue. I'll link to it as soon as I create the PR.
cc: @danmosemsft, @Anipik, @maryamariyan, @jkotas, @pjanotti, @benaadams, @ahsonkhan