This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use non-inlineable overload for rare CompareOrdinalIgnoreCase path #17492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes regression introduced in dotnet#17237.
|
Can you explain the fix? |
|
Many layers of different overloads combined with fast and slow paths makes this code pretty sensitive. I hope we will get a chance to simplify this in future (#16434 has some good changes that are going in the right direction, I think). |
Before this change, the two argument method on the rare path got inlined and made the prolog of this method larger and in turn regressed the method for the case of two identical strings. After this change, the six argument method on the rare path is not getting inlined and so it maintains the performance characteristics that it used to have. (The change is a one liner revert of changes made in #17237.) |
ahsonkhan
approved these changes
Apr 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes regression introduced in #17237.