This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[Arm64/Linux] Use platform memset/memcpy #17536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Apr 13, 2018
src/vm/arm64/crthelpers.S
Outdated
| // dst = (uint64_t*)dst + 1; | ||
| // count-=8; | ||
| // } | ||
| // It is IMPORANT that the exception handling code is able to find these guys |
There was a problem hiding this comment.
Nit: typo for IMPORTANT
There was a problem hiding this comment.
Cut and paste from typo in amd64
adityamandaleeka
approved these changes
Apr 13, 2018
Fixes buggy memset implementation Use heavily optimized platform implementation Follows amd64 & arm precedent
sdmaclea
force-pushed
the
PR-ARM64-LINUX-MEMx-Use-platform
branch
from
bbbb5c1 to
7275387
Compare
janvorli
approved these changes
Apr 13, 2018
This was referenced Apr 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes buggy JIT_MemSet implementation
Use heavily optimized platform implementation
Follows linux amd64 & arm precedent
@janvorli PTAL
@dotnet/arm64-contrib FYI
Fixes #17167, #17168, & #17169 which were actually due to bugs in JIT_MemSet in rare corner cases
I would like this for 2.1