This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[No Merge]Adding SSE4.2 STTNI intrinsic APIs #19958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we simplify enum names? |
src/System.Private.CoreLib/shared/System/Runtime/Intrinsics/X86/Enums.cs
Show resolved
Hide resolved
src/System.Private.CoreLib/shared/System/Runtime/Intrinsics/X86/Enums.cs
Outdated
Show resolved
Hide resolved
src/System.Private.CoreLib/shared/System/Runtime/Intrinsics/X86/Enums.cs
Outdated
Show resolved
Hide resolved
CarolEidt
reviewed
Sep 20, 2018
There was a problem hiding this comment.
I don't think we should have a "Redesign" PR in coreclr.
I think we should first discuss the kinds of design decisions we're talking about in the corefx issue (https://github.com/dotnet/corefx/issues/30373)
src/System.Private.CoreLib/shared/System/Runtime/Intrinsics/X86/Enums.cs
Outdated
Show resolved
Hide resolved
| /// PCMPISTRI xmm, xmm/m128, imm8 | ||
| /// int _mm_cmpistrs (__m128i a, __m128i b, const int imm8) | ||
| /// </summary> | ||
| public static bool CompareNoMatchAndRightNotTerminated(Vector128<sbyte> left, Vector128<sbyte> right, StringComparisonMode mode) { throw new PlatformNotSupportedException(); } |
There was a problem hiding this comment.
This is so verbose - since we have RightTerminated doesn't it make sense for the lack of that modifier to imply that it is not right terminated?
Also, could we think of a better way to express CompareNoMatch?
This was referenced Nov 8, 2018
fiigii
changed the title
|
@fiigii, can this be closed for now; until we have a better design? |
This was referenced Jan 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SSE4.2 STTNI intrinsic APIs that need to be reviewed.