This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move ObjectAllocator phase to run right after inlining. #20377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndyAyersMS @echesakov @dotnet/jit-contrib PTAL |
|
This is one of the steps listed in #20253 |
This change will support object stack allocation for the following reasons: 1. Objects should be allocated on the stack before struct promotion phase so that their fields have a chance to be promoted. 2. Eventually object stack allocation will be performed in the same phase as inlining since inlining heuristics will need to be aware of object stack allocation opportunities. I verified no x64 diffs with jit-diffs --frameworks --tests --pmi
erozenfeld
force-pushed
the
ObjectAllocatorPhaseOrder
branch
from
77c1b44 to
4d4f05d
Compare
echesakov
approved these changes
Oct 11, 2018
|
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test |
A-And
pushed a commit
to A-And/coreclr
that referenced
this pull request
Nov 20, 2018
This change will support object stack allocation for the following reasons: 1. Objects should be allocated on the stack before struct promotion phase so that their fields have a chance to be promoted. 2. Eventually object stack allocation will be performed in the same phase as inlining since inlining heuristics will need to be aware of object stack allocation opportunities. I verified no x64 diffs with jit-diffs --frameworks --tests --pmi
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will support object stack allocation for the following reasons:
so that their fields have a chance to be promoted.
as inlining since inlining heuristics will need to be aware of object stack allocation
opportunities.
I verified no x64 diffs with jit-diffs --frameworks --tests --pmi