Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Update Unicode data to version 11 #20529

Merged
merged 4 commits into from
Oct 24, 2018
Merged

Update Unicode data to version 11 #20529

merged 4 commits into from
Oct 24, 2018

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Oct 22, 2018

No description provided.

@tarekgh tarekgh requested a review from krwq October 22, 2018 23:18
@tarekgh tarekgh self-assigned this Oct 22, 2018
@tarekgh tarekgh added this to the 3.0 milestone Oct 22, 2018
@tarekgh
Copy link
Member Author

tarekgh commented Oct 22, 2018

I am going to update the tests on corefx too.

CC @GrabYourPitchforks

@tarekgh
Copy link
Member Author

tarekgh commented Oct 22, 2018 •
edited
Loading

https://github.com/dotnet/corefx/issues/32951
dotnet/corefx#32968

krwq
krwq approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really tell if the data is right but the process seems reasonable from offline conversation

@jkotas
Copy link
Member

jkotas commented Oct 22, 2018

@dotnet-bot test this please

@tarekgh tarekgh mentioned this pull request Oct 22, 2018
Merged
@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Oct 23, 2018 •
edited
Loading

I'd love for us to add an API to get the version of the Unicode spec that's burned in to the product. Otherwise LGTM.
(And such an API would really be a separate issue from this one, anyway.)

@tarekgh
Copy link
Member Author

tarekgh commented Oct 23, 2018

System.Globalization.Tests.CharUnicodeInfoGetUnicodeCategoryTests.GetUnicodeCategory is expected to fail in this PR. I already have other PR in corefx for fixing this test.

@jkotas
Copy link
Member

jkotas commented Oct 23, 2018

Disable the affected tests in https://github.com/dotnet/coreclr/blob/master/tests/CoreFX/CoreFX.issues.json . We want to keep the CI green.

@jkotas
Copy link
Member

jkotas commented Oct 23, 2018

Should we move this file to shared CoreLib partition as part of this and update the data in CoreRT/ProjectN as well?

@tarekgh
Copy link
Member Author

tarekgh commented Oct 23, 2018

Should we move this file to shared CoreLib partition as part of this and update the data in CoreRT/ProjectN as well?

I think this will be a good idea. I'll try to modify the code to do that. and we can update the CoreRT when we get the change mirrored.

jkotas
jkotas reviewed Oct 23, 2018
View reviewed changes
src/System.Private.CoreLib/System.Private.CoreLib.csproj
@@ -372,7 +372,6 @@
<Compile Include="$(BclSourcesRoot)\System\Reflection\Metadata\AssemblyExtensions.cs" />
</ItemGroup>
<ItemGroup>
<Compile Include="$(BclSourcesRoot)\System\Globalization\CharUnicodeInfoData.cs" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please delete this file as well?

Copy link
Member Author

@tarekgh tarekgh Oct 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I did move command in PS window and I thought it deleted the original file but it didn't. anyway, I'll fix that. Thanks for the catch.

@jkotas
Copy link
Member

jkotas commented Oct 23, 2018

Disable the affected tests in https://github.com/dotnet/coreclr/blob/master/tests/CoreFX/CoreFX.issues.json

You will need to do this before merging this PR...

@tarekgh
Copy link
Member Author

tarekgh commented Oct 23, 2018

@jkotas does CI pick the tests from corefx repro master? or it pick it up from some other place? I am asking because I have fixed the test on corefx which should work fine now.

@jkotas
Copy link
Member

jkotas commented Oct 23, 2018

The CI picks up a fixed snapshot that is several weeks old. Your fix won't propagate into this snapshot anytime soon.

@tarekgh
Copy link
Member Author

tarekgh commented Oct 24, 2018

@dotnet/dnceng do you know how I can restart "Windows_NT arm Cross Checked Innerloop Build and Test " leg?

@mmitche
Copy link
Member

mmitche commented Oct 24, 2018

@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test

@tarekgh
Copy link
Member Author

tarekgh commented Oct 24, 2018

@mmitche thanks for help. just wondering why I can start other legs without specifying "@dotnet-bot" while I cannot do it for "Windows_NT arm Cross Checked Innerloop Build and Test". I am just curious to know :-)

@mmitche
Copy link
Member

mmitche commented Oct 24, 2018

@dotnet-bot is just a convention, not required. It's generally just "test "

@tarekgh
Copy link
Member Author

tarekgh commented Oct 24, 2018

I am pretty sure I tried "test" a couple of times with this leg and didn't work.

@tarekgh tarekgh merged commit 11c5d6c into dotnet:master Oct 24, 2018
dotnet-maestro-bot pushed a commit to dotnet-maestro-bot/corefx that referenced this pull request Oct 24, 2018
@tarekgh @dotnet-bot
Update Unicode data to version 11 (dotnet/coreclr#20529)
2fbf17e 
* Update Unicode data to version 11

* Move CharUnicodeInfoData.cs to the hsared folder

* Delete un-needed file

* Disable the failed test

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot pushed a commit to dotnet-maestro-bot/corert that referenced this pull request Oct 24, 2018
@tarekgh @dotnet-bot
Update Unicode data to version 11 (dotnet/coreclr#20529)
059ef15 
* Update Unicode data to version 11

* Move CharUnicodeInfoData.cs to the hsared folder

* Delete un-needed file

* Disable the failed test

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
tarekgh added a commit to dotnet/corefx that referenced this pull request Oct 24, 2018
@tarekgh
Update Unicode data to version 11 (dotnet/coreclr#20529)
eb9da0a 
* Update Unicode data to version 11

* Move CharUnicodeInfoData.cs to the hsared folder

* Delete un-needed file

* Disable the failed test

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
tarekgh added a commit to tarekgh/coreclr that referenced this pull request Oct 25, 2018
@tarekgh
Get the real update for Unicode 11 data
863a037 
In the PR dotnet#20529 we have used the old existing data when we moved the file CharunicodeInfoData.cs to shared folder.
This change is to restore the actual updated file.
@tarekgh tarekgh mentioned this pull request Oct 25, 2018
Merged
tarekgh added a commit to dotnet/corert that referenced this pull request Oct 25, 2018
@tarekgh
Update Unicode data to version 11 (dotnet/coreclr#20529)
c2f4685 
* Update Unicode data to version 11

* Move CharUnicodeInfoData.cs to the hsared folder

* Delete un-needed file

* Disable the failed test

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@tarekgh tarekgh mentioned this pull request Oct 25, 2018
Merged
jkotas pushed a commit that referenced this pull request Oct 25, 2018
@tarekgh @jkotas
Get the real update for Unicode 11 data (#20589)
bbf0902 
In the PR #20529 we have used the old existing data when we moved the file CharunicodeInfoData.cs to shared folder.
This change is to restore the actual updated file.
A-And pushed a commit to A-And/coreclr that referenced this pull request Nov 20, 2018
@tarekgh @A-And
Update Unicode data to version 11 (dotnet#20529)
11a7171 
* Update Unicode data to version 11

* Move CharUnicodeInfoData.cs to the hsared folder

* Delete un-needed file

* Disable the failed test
A-And pushed a commit to A-And/coreclr that referenced this pull request Nov 20, 2018
@tarekgh @A-And
Get the real update for Unicode 11 data (dotnet#20589)
517f770 
In the PR dotnet#20529 we have used the old existing data when we moved the file CharunicodeInfoData.cs to shared folder.
This change is to restore the actual updated file.
@tarekgh tarekgh deleted the Unicode11 branch March 25, 2019 15:29
@GrabYourPitchforks GrabYourPitchforks mentioned this pull request Nov 27, 2019
Merged
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@tarekgh
Update Unicode data to version 11 (dotnet/coreclr#20529)
6a89445 
* Update Unicode data to version 11

* Move CharUnicodeInfoData.cs to the hsared folder

* Delete un-needed file

* Disable the failed test


Commit migrated from dotnet/coreclr@11c5d6c
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@tarekgh @jkotas
Get the real update for Unicode 11 data (dotnet/coreclr#20589)
1d69365 
In the PR dotnet/coreclr#20529 we have used the old existing data when we moved the file CharunicodeInfoData.cs to shared folder.
This change is to restore the actual updated file.

Commit migrated from dotnet/coreclr@bbf0902
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@krwq krwq krwq approved these changes

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Globalization
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tarekgh @jkotas @GrabYourPitchforks @mmitche @krwq