This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update documentation for changing CoreLib #21201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
reviewed
Nov 26, 2018
| - Link the two PRs together via comment in PR description | ||
| - Both PRs will reviewed together by the project maintainers | ||
| - CoreFX tests run on CoreCLR PRs are using old published build. You may need to disable the outdated tests in https://github.com/dotnet/coreclr/blob/master/tests/CoreFX/CoreFX.issues.json to make your PR green. | ||
| - CoreCLR PR will be merged first |
There was a problem hiding this comment.
Should we mention the automatic source mirroring that happens?
i.e. something like this:
dotnet/corefx#33687 (comment)
ahsonkhan
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
LGTM. Thanks!
I have been pointing contributors to this doc recently: dotnet/corefx#33687 / dotnet/corefx#33695
OlegAxenow
reviewed
Nov 27, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.