This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add System.Reflection.Emit.DynamicILInfo #21945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Try avoiding adding DynamicScope by adding internal ctor with object arg - Remove unnecessary attributes - Remove #pragma warning disable 618
Anipik
approved these changes
Jan 10, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Show resolved
Hide resolved
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
danmoseley
approved these changes
Jan 10, 2019
benaadams
reviewed
Jan 10, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 12, 2019
jkotas
approved these changes
Jan 12, 2019
jkotas
suggested changes
Jan 12, 2019
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Jan 13, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Making DynamicILInfo and its API impls public * Remove DynamicScope input from ctor args Commit migrated from dotnet/coreclr@908891c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/dotnet/corefx/issues/12055
cc: @Anipik @danmosemsft
related corefx PR: dotnet/corefx#34532