This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Move AsyncCausality to shared partition #22062
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
src/System.Private.CoreLib/shared/System/Threading/Tasks/AsyncCausalityTracer.Noop.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Diagnostics; | ||
|
|
||
| namespace System.Threading.Tasks | ||
| { | ||
| internal enum CausalityTraceLevel | ||
| { | ||
| Required = 0, | ||
| Important = 1, | ||
| Verbose = 2, | ||
| } | ||
|
|
||
| internal enum AsyncCausalityStatus | ||
| { | ||
| Started = 0, | ||
| Completed = 1, | ||
| Canceled = 2, | ||
| Error = 3, | ||
| } | ||
|
|
||
| internal enum CausalityRelation | ||
| { | ||
| AssignDelegate = 0, | ||
| Join = 1, | ||
| Choice = 2, | ||
| Cancel = 3, | ||
| Error = 4, | ||
| } | ||
|
|
||
| internal enum CausalitySynchronousWork | ||
| { | ||
| CompletionNotification = 0, | ||
| ProgressNotification = 1, | ||
| Execution = 2, | ||
| } | ||
|
|
||
| // | ||
| // Empty implementation of AsyncCausality events | ||
| // | ||
| internal static class AsyncCausalityTracer | ||
| { | ||
| public static bool LoggingOn => false; | ||
|
|
||
| [Conditional("NOOP_ASYNCCASUALITYTRACER")] | ||
| public static void EnableToETW(bool enabled) | ||
| { | ||
| } | ||
|
|
||
| [Conditional("NOOP_ASYNCCASUALITYTRACER")] | ||
| public static void TraceOperationCreation(CausalityTraceLevel traceLevel, int taskId, string operationName, ulong relatedContext) | ||
| { | ||
| } | ||
|
|
||
| [Conditional("NOOP_ASYNCCASUALITYTRACER")] | ||
| public static void TraceOperationCompletion(CausalityTraceLevel traceLevel, int taskId, AsyncCausalityStatus status) | ||
| { | ||
| } | ||
|
|
||
| [Conditional("NOOP_ASYNCCASUALITYTRACER")] | ||
| public static void TraceOperationRelation(CausalityTraceLevel traceLevel, int taskId, CausalityRelation relation) | ||
| { | ||
| } | ||
|
|
||
| [Conditional("NOOP_ASYNCCASUALITYTRACER")] | ||
| public static void TraceSynchronousWorkStart(CausalityTraceLevel traceLevel, int taskId, CausalitySynchronousWork work) | ||
| { | ||
| } | ||
|
|
||
| [Conditional("NOOP_ASYNCCASUALITYTRACER")] | ||
| public static void TraceSynchronousWorkCompletion(CausalityTraceLevel traceLevel, CausalitySynchronousWork work) | ||
| { | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method and the one below can be removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It cannot, it's used at https://github.com/dotnet/coreclr/pull/22062/files#diff-290cb2024350a19884ed781417721d54R581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I meant from
AsyncCausalitySupportand you already did that.