Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Reenable corefx System.Linq.Expressions.Tests. #22362

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Reenable corefx System.Linq.Expressions.Tests. #22362

merged 1 commit into from
Feb 4, 2019

Conversation

@sandreenko
Copy link

@sandreenko sandreenko commented Feb 2, 2019 •
edited
Loading

Link #19457

@sandreenko sandreenko added disabled-test The test is disabled in source code against the issue test-corefx Related to a corefx test run in coreclr labels Feb 2, 2019
@sandreenko
Copy link
Author

sandreenko commented Feb 2, 2019

@dotnet-bot test Windows_NT arm64 Cross Checked corefx_jitstress1 Build and Test
@dotnet-bot test Windows_NT arm64 Cross Checked corefx_jitstress2 Build and Test
@dotnet-bot test Windows_NT arm Cross Checked corefx_jitstress1 Build and Test
@dotnet-bot test Windows_NT arm Cross Checked corefx_jitstress2 Build and Test

@sandreenko
Copy link
Author

sandreenko commented Feb 4, 2019

3 jobs are failing with Microsoft.VisualBasic.Tests.ConversionsTests.ToDouble_Object_ReturnsExpected(value: 18446744073709551615, expected: 1.84467440737096E+19) [FAIL]

The issue is described here #22040 (comment).
Will be fixed once dotnet/corefx#35016 is propagated here.

System.Linq.Expressions.Tests do not fail.

@sandreenko
Copy link
Author

sandreenko commented Feb 4, 2019

PTAL @dotnet/jit-contrib

@sandreenko sandreenko merged commit 7253eab into dotnet:master Feb 4, 2019
@sandreenko sandreenko deleted the close19457 branch February 4, 2019 19:13
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Reenable corefx System.Linq.Expressions.Tests. (dotnet/coreclr#22362)
e7d4341 
Commit migrated from dotnet/coreclr@7253eab
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@echesakov echesakov echesakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

disabled-test The test is disabled in source code against the issue test-corefx Related to a corefx test run in coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sandreenko @echesakov