DictionarySlim backport improvements, retaining more entropy

[MarcoRossignoli]

Replacement of #22832 due to CI issue
Analysis of perf/diffs are on old PR

/cc @danmosemsft @jkotas

[MarcoRossignoli]

CI broken on Linux arm unrelated due to https://github.com/dotnet/coreclr/issues/23582

EDIT: fixed in #23590

[MarcoRossignoli]

/azp run

[MarcoRossignoli]

/azp help

[azure-pipelines]

Supported commands
     help:
          Get descriptions, examples and documentation about supported commands
          Example: help "command_name"
     run:
          Run all pipelines or a specific pipeline for this repository using a comment. Use
          this command by itself to trigger all related pipelines, or specify a pipeline
          to run.
          Example: "run" or "run pipeline_name"

See additional documentation.

[MarcoRossignoli]

/AzurePipelines run

[MarcoRossignoli]

@safern sorry for disturb, I cannot re-run CI sure I'm missing something...I read doc again...but no luck.

[danmoseley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 6 pipeline(s).

[MarcoRossignoli]

Uh...discrimination 😄 thank's!

[MarcoRossignoli]

CI issue, it seems related to https://github.com/dotnet/coreclr/issues/23545

EDIT: disabled test in #23598

[MarcoRossignoli]

/azp run

[MarcoRossignoli]

@danmosemsft I cannot run CI anymore 😭

[danmoseley]

Maybe @safern knows why

[safern]

I think the problem is that you're a contributor and not a Collaborator in coreclr, but in corefx you're a collaborator, that is why there you were able to trigger builds.

https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops#trigger-builds-using-github-pull-request-comments

@danmosemsft just sent an invite, so once you accept that you'll be able to trigger builds in coreclr as well 😄

I'm sad that triggering and re-running builds became hard and painful for contributors 😢

[MarcoRossignoli]

Thank's guys!

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 6 pipeline(s).

[MarcoRossignoli]

CI is not green there are some issue with some tests unrelated to dic(with open issue), I retry for "Catastrophic Failure" on Ubuntu.1804.Arm64.On.Docker.Open-arm64

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 6 pipeline(s).

[MarcoRossignoli]

CI issue related to https://github.com/dotnet/coreclr/issues/23429
https://mc.dot.net/#/user/coreclr-outerloop/pr~2Fdotnet~2Fcoreclr~2Frefs~2Fpull~2F23591~2Fmerge/test~2Ffunctional~2Fcli~2F/20190402.71/workItem/Loader.AssemblyDependencyResolverTests/analysis/xunit/Loader_AssemblyDependencyResolverTests._AssemblyDependencyResolverTests_AssemblyDependencyResolverTests_~2F_AssemblyDependencyResolverTests_AssemblyDependencyResolverTests_sh

EDIT: fixed in #23470

[MarcoRossignoli]

@safern is this tab https://dev.azure.com/dnceng/public/_build/results?buildId=140379&view=ms.vss-test-web.build-test-results-tab reliable to check which test fails(I hope so, very useful)?
I mean before to go deep to https://mc.dot.net to check the errors.

[safern]

@safern is this tab https://dev.azure.com/dnceng/public/_build/results?buildId=140379&view=ms.vss-test-web.build-test-results-tab reliable to check which test fails(I hope so, very useful)?
I mean before to go deep to https://mc.dot.net to check the errors.

For coreclr, it should be 😄 -- for corefx, we don't put results there yet (we're missing a retry feature), once that feature is available, corefx should move there 😄

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 6 pipeline(s).

[MarcoRossignoli]

execution failed Ubuntu.1804.Arm64.Open-arm64:Checked-no_tiered_compilation https://mc.dot.net/#/user/coreclr-ci/pr~2Fdotnet~2Fcoreclr~2Frefs~2Fpull~2F23591~2Fmerge/test~2Ffunctional~2Fcli~2F/20190403.72/workItem/reflection.Modifiers/wilogs

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[MarcoRossignoli]

@danmosemsft @jkotas I'm struggling to obtain green CI, is possible at the moment or there are issue around?

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[MarcoRossignoli]

unrelated outerloop fail https://mc.dot.net/#/user/coreclr-outerloop/pr~2Fdotnet~2Fcoreclr~2Frefs~2Fpull~2F23591~2Fmerge/test~2Ffunctional~2Fcli~2F/20190406.71/workItem/Loader.classloader/wilogs
other outerloop gcstress/jitminopts/jitstress seems old(3 days ago)

[danmoseley]

@Anipik can you please help this get merged? (Check the code matches what was signed off on in the linked original PR)

[MarcoRossignoli]

Thank's Dan

[Anipik]

@jkotas the code is exactly similar to the code that was approved in the previous PR.
The outerloop test failure is not getting repro'd on the local machine. Do you have any context on the failure ?

[jkotas]

The outerloop test failure is not getting repro'd on the local machine. Do you have any context on the failure ?

I have not seen this failure before. It does not look related to this change.

[danmoseley]

I agree these specific failures do not look related.

[danmoseley]

Thanks for your patience @MarcoRossignoli

[MarcoRossignoli]

No worries!