This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Nullable: All remaining exceptions #23676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, yes, I've got those edited locally. |
danmoseley
reviewed
Apr 3, 2019
danmoseley
reviewed
Apr 3, 2019
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/RuntimeWrappedException.cs
Show resolved
Hide resolved
danmoseley
reviewed
Apr 3, 2019
src/System.Private.CoreLib/shared/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs
Show resolved
Hide resolved
danmoseley
reviewed
Apr 3, 2019
src/System.Private.CoreLib/shared/System/Runtime/ExceptionServices/ExceptionNotification.cs
Show resolved
Hide resolved
danmoseley
reviewed
Apr 3, 2019
src/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Apr 3, 2019
src/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs
Outdated
Show resolved
Hide resolved
danmoseley
approved these changes
Apr 3, 2019
stephentoub
approved these changes
Apr 3, 2019
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Apr 5, 2019
* Nullable: All remaining exceptions * Fix build break and PR Feedback Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Apr 6, 2019
* Nullable: All remaining exceptions * Fix build break and PR Feedback Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 9, 2019
* Nullable: All remaining exceptions * Fix build break and PR Feedback Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 9, 2019
* Nullable: All remaining exceptions * Fix build break and PR Feedback Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Apr 9, 2019
* Nullable: All remaining exceptions * Fix build break and PR Feedback Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Anipik
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 9, 2019
* Nullable: All remaining exceptions * Fix build break and PR Feedback Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 10, 2019
* Nullable: All remaining exceptions * Fix build break and PR Feedback Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Nullable: All remaining exceptions * Fix build break and PR Feedback Commit migrated from dotnet/coreclr@cdcca03
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stephentoub I left out of this PR:
System\Threading\Tasks\TaskCanceledException.csSystem\Threading\Tasks\TaskExceptionHolder.csSystem\Threading\Tasks\TaskSchedulerException.csI didn't know if you were already working on them locally, I didn't want to duplicate work. If you're not, just let me know and I'll include them on my PR.