This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Improve metadata perf and refactor ilasm/ildasm metadata usage #25144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Jun 13, 2019
| @@ -8,7 +8,6 @@ add_definitions(-D__ILASM__) | |||
| add_definitions(-DFEATURE_CORECLR) | |||
|
|
|||
| include_directories(.) | |||
| include_directories(../ildasm/unixcoreclrloader) | |||
There was a problem hiding this comment.
Delete everything in unixcoreclrloader directory?
There was a problem hiding this comment.
Yeah, I need to do that before checkin, as well as change the IMDInternalImport guid, so nobody gets burned with invalid vtable dispatches on this change if they do something like use a dbi with a non-compatible dac. This is still WIP, as while I managed to get the Windows build to be workable, the Linux/Mac build is broken.
jkotas
reviewed
Jun 13, 2019
src/ildasm/dasm.cpp
Outdated
| @@ -308,32 +307,17 @@ extern CQuickBytes * g_szBuf_JUMPPT; | |||
| extern CQuickBytes * g_szBuf_UnquotedProperName; | |||
| extern CQuickBytes * g_szBuf_ProperName; | |||
|
|
|||
| #ifdef FEATURE_PAL | |||
| CoreCLRLoader *g_loader; | |||
| #endif | |||
| MetaDataGetDispenserFunc metaDataGetDispenser; | |||
There was a problem hiding this comment.
Nit: These vars are not needed anymore. Can just call directly.
davidwrighton
changed the title
janvorli
reviewed
Jun 14, 2019
src/ilasm/CMakeLists.txt
Outdated
| ) | ||
| else() | ||
| list(APPEND ILASM_LINK_LIBRARIES | ||
| ${START_WHOLE_ARCHIVE} # force all PAL objects to be included so all exports are available |
There was a problem hiding this comment.
This ${START_WHOLE_ARCHIVE} should not be needed. Only the coreclr needs this as it exports symbols, some of which are from PAL.
src/ildasm/exe/CMakeLists.txt
Outdated
| ) | ||
| else() | ||
| list(APPEND ILDASM_LINK_LIBRARIES | ||
| ${START_WHOLE_ARCHIVE} # force all PAL objects to be included so all exports are available |
- Move enumerator functions to be directly implemented instead of relying on COM/vtable dispatch - Delete unused functions - Replace TypeDef enumeration logic to be the same as the general case Build metadata into ildasm and ilasm instead of referencing coreclr - SHA1Hash class moved to utilcode - careful detachment of bindings between metadata and runtime - Able to reuse wks build of metadata logic for ilasm/ildasm
davidwrighton
force-pushed
the
reduce_metadata_indirections
branch
from
f7df3ec
to
4805160
Compare
- Remove unnecessary function pointer indirection - Update guid of IMDInternalImport as the api has changed
davidwrighton
changed the title
davidwrighton
commented
Jul 26, 2019
src/md/staticmd/apis.cpp
Outdated
| // %%Function: MetaDataGetDispenser | ||
| // This function gets the Dispenser interface given the CLSID and REFIID. | ||
| // --------------------------------------------------------------------------- | ||
| STDAPI DLLEXPORT MetaDataGetDispenser( // Return HRESULT |
briansull
approved these changes
Jul 26, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…t/coreclr#25144) * Optimize enumeration in IMDInternal - Move enumerator functions to be directly implemented instead of relying on COM/vtable dispatch - Delete unused functions - Replace TypeDef enumeration logic to be the same as the general case - Update guid of IMDInternalImport as the api has changed Build metadata into ildasm and ilasm instead of referencing coreclr - SHA1Hash class moved to utilcode - careful detachment of bindings between metadata and runtime - Able to reuse wks build of metadata logic for ilasm/ildasm Commit migrated from dotnet/coreclr@ef7767a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change currently conflates 2 change