-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
eng/Versions.props
Outdated
<!-- Always use shipping version instead of dummy versions --> | ||
<DotNetUseShippingVersions>true</DotNetUseShippingVersions> | ||
<PreReleaseVersionLabel>preview8</PreReleaseVersionLabel> | ||
<PreReleaseVersionLabel>preview0</PreReleaseVersionLabel> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may change
|
@RussKeldorph who would be the right person to ask about the CoreFx testing leg? I'm guessing it's hardcoding a |
@BruceForstall Is this going to be fixed when we ingest new assets? Should we just disable these jobs (or let them run red) until that happens? |
The corefx jobs (in coreclr repo) pull a set of corefx tests published by the corefx official build. Looks like they're built with a
Maybe that forces it? There is also tests\src\Common\CoreFX\CoreFX.depproj with:
Does that need to be updated? That file also references published CoreFX packages using versions from Versions.props. Seems reasonable to let corefx jobs run red until after the first official builds happen with the new branding. (Although perhaps you've already pushed an official build, and there are other issues?) |
@BruceForstall we haven't published an official build yet of CoreFx w/ 5.0. We can update that file once we decide what we're doing with the |
* Update branding to 5.0 * Update Prerelease to alpha1 Commit migrated from dotnet/coreclr@0cc81b6
Update branding in master to 5.0 - please don't merge before noon on 7/16.
Updates the repo's
ProductVersion
,FileVersion
,PackageVersion
, and theAssemblyVersion
of System.Private.Corelib to 5.0. We still need to figure out what (if anything) needs to be done to guard against overlapping FileVersions on coreclr.dll.@RussKeldorph PTAL (along with whoever else should be involved)