This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enable MHR support on OSX #26193
Merged
Enable MHR support on OSX #26193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move JIT_WriteBarrier that is modified at runtime to a dynamically allocated memory instead of making a page in libcoreclr.dylib RWX. * Update PAL to add MEM_JIT flag for allocations and reservations of executable memory. * Update native runtime in EH and stack unwinding areas so that it can unwind from the write barrier copy. That code has no unwind info, so without special handling, runtime would not be able to unwind from it.
|
@jkotas - this PR contains all the stuff you have already reviewed and that I've reverted in the past due to the missing JIT_Stelem_Ref changes. And in addition, it fixes the JIT_Stelem_Ref to correctly jump to the copy of the JIT_WriteBarrier code instead of the readonly original in the binary. |
jkotas
approved these changes
Aug 16, 2019
|
cc: @odhanson |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Enable MHR support on OSX * Move JIT_WriteBarrier that is modified at runtime to a dynamically allocated memory instead of making a page in libcoreclr.dylib RWX. * Update PAL to add MEM_JIT flag for allocations and reservations of executable memory. * Update native runtime in EH and stack unwinding areas so that it can unwind from the write barrier copy. That code has no unwind info, so without special handling, runtime would not be able to unwind from it. * Fix JIT_Stelem_Ref calls to JIT_WriteBarrier Commit migrated from dotnet/coreclr@0e64ecf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allocated memory instead of making a page in libcoreclr.dylib RWX.
executable memory.
unwind from the write barrier copy. That code has no unwind info, so
without special handling, runtime would not be able to unwind from
it.