This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Manually marshal parameters for EventPipeInternal.Enable. #26496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Sep 4, 2019
src/System.Private.CoreLib/src/System/Diagnostics/Eventing/EventPipe.cs
Outdated
Show resolved
Hide resolved
…ntPipe.cs Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
davidwrighton
approved these changes
Sep 4, 2019
…lly-marshal-qcall
sywhang
approved these changes
Sep 5, 2019
…lly-marshal-qcall
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…eclr#26496) * Manually marshal parameters for EventPipeInternal.Enable. * Update src/System.Private.CoreLib/src/System/Diagnostics/Eventing/EventPipe.cs Co-Authored-By: Jan Kotas <jkotas@microsoft.com> Commit migrated from dotnet/coreclr@db04a9a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #26340, I realized that for various technical reasons we don't have an easy way to embed the struct marshal IL stubs into R2R images. So, as part of that PR, we are going to disable generating struct stubs in System.Private.CoreLib (the only place we would have embed them in the first place).
I discovered that EventPipeInternal::Enable has to marshal an array of non-blittable structs, so to keep it inlining (and reduce the number of stubs in System.Private.CoreLib), this PR manually marshals the parameters for EventPipeInternal.Enable.
cc: @davidwrighton