Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Make StringComparer.Create throw ArgumentNullException #26570

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Make StringComparer.Create throw ArgumentNullException #26570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f03bbf
Make StringComparer.Create throw ArgumentNullException
TylerBrinkley Sep 6, 2019
ba61448
Update CoreFX.issues.rsp
TylerBrinkley Sep 9, 2019
164aca1
Merge branch 'master' into patch-1
TylerBrinkley Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Private.CoreLib/shared/System/StringComparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static StringComparer Create(CultureInfo culture, CompareOptions options)
{
if (culture == null)
{
throw new ArgumentException(nameof(culture));
throw new ArgumentNullException(nameof(culture));
}

return new CultureAwareComparer(culture, options);
Expand Down
3 changes: 3 additions & 0 deletions tests/CoreFX/CoreFX.issues.rsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@
# Test failure: https://github.com/dotnet/corefx/issues/39223
-nomethod System.ComponentModel.TypeConverterTests.FontConverterTest.TestConvertFrom

# Test failure: https://github.com/dotnet/coreclr/pull/26570
-nomethod System.Tests.StringComparerTests.CreateCultureOptions_InvalidArguments_Throws

# corefx tests need to be updated for changes to GetHashCode
-nomethod System.Numerics.Tests.GenericVectorTests.GetHashCodeInt16
-nomethod System.Numerics.Tests.GenericVectorTests.GetHashCodeInt32
Expand Down