This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix ADDR(IND(tree))=>tree transformation in morph. #27108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADDR(IND(tree)) => tree transformation was losing zero field sequence annotation that was causing incorrect value numbering and asserts in the CSE optimization. Fixes #27107.
@dotnet/jit-contrib PTAL |
x64 frameworks diffs:
|
briansull
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BruceForstall
approved these changes
Oct 9, 2019
x64 benchmarks diffs:
|
The change unblocked some CSEs in the benchmark method showing an improvement. |
erozenfeld
added a commit
to erozenfeld/coreclr
that referenced
this pull request
Oct 9, 2019
dotnet#27108 fixed #27107 but the tests had an incorrect placeholder name. Rename the test directory and files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADDR(IND(tree)) => tree transformation was losing zero field
sequence annotation that was causing incorrect value numbering
and asserts in the CSE optimization.
Fixes #27107.