This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[3.1 port] Improve the performance of Environment.WorkingSet in Windows (#26522) #27212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…26522) * Use win32 api directly for workingset counter * Fix build warnings * Removing useless code * more cleanup * remove size annotation * remove useless comment * Move all the changes to Environment.WorkingSet and remove it from RuntimeEventSourceHelper * removing useless usings * Use kernel32.dll instead of psapi.dll * Code review feedback * Remove newline change * More code review nits
|
Do we have similar performance problem on Linux? Just wondering. Otherwise, approved. |
Yes: https://github.com/dotnet/coreclr/issues/23736#issuecomment-530627464 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #26522.
Environment.WorkingSetAPI was not made to be performant, so it was using reflection to call System.Diagnostics.Process API, which internally allocates aProcessInfoobject and fills up a lot of irrelevant information that gets thrown away. This changes Environment.WorkingSet API to call into the Windows API for fetching the working set directly to improve its performance on Windows.Customer Impact
Bing reported this API to be a blocker for adopting the runtime performance counters in their production environment.
Regression?
No
Risk
Low. Performance tests showed an improvement of ~2000x speedup with this change.