This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Compile with gcc 4.8 #27625
Merged
Compile with gcc 4.8 #27625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from coreclr/src/vm/dumpdiagnosticprotocolhelper.h:11:0,
from coreclr/src/vm/dumpdiagnosticprotocolhelper.cpp:7:
coreclr/src/vm/diagnosticsprotocol.h: In member function ‘bool DiagnosticsIpc::IpcMessage::Initialize(HRESULT)’:
coreclr/src/vm/diagnosticsprotocol.h:239:56: error: call of overloaded ‘Initialize(const DiagnosticsIpc::IpcHeader&, HRESULT&)’ is ambiguous
return Initialize(GenericErrorHeader, error);
^
coreclr/src/vm/diagnosticsprotocol.h:239:56: note: candidates are:
coreclr/src/vm/diagnosticsprotocol.h:196:14: note: bool DiagnosticsIpc::IpcMessage::Initialize(DiagnosticsIpc::IpcHeader, T&) [with T = int]
bool Initialize(IpcHeader header, T& payload)
^
coreclr/src/vm/diagnosticsprotocol.h:213:14: note: bool DiagnosticsIpc::IpcMessage::Initialize(DiagnosticsIpc::IpcHeader, T&&) [with T = int&]
bool Initialize(IpcHeader header, T&& payload)
^
|
We should be able to close #26929 and #25529 after this change. |
jkotas
reviewed
Nov 2, 2019
|
LGTM otherwise |
jkotas
approved these changes
Nov 2, 2019
am11
reviewed
Nov 2, 2019
am11
approved these changes
Nov 2, 2019
There was a problem hiding this comment.
👍
I didn't realize until now that C++11 is supported in 4.8: https://gcc.gnu.org/gcc-4.8/cxx0x_status.html
Note that CoreFX uses C11 _Generic in one place, which requires minimum gcc v4.9. So it would probably be good that we set 4.9 as baseline (especially once the repos are consolidated few days from now).
|
Will backport the patch to 3.1 branch? Thanks, |
|
3.1 branch unfortunately won't work because full GCC compilation has been only enabled on master branch only recently. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@am11 @janvorli @jkotas