This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Port .NET 5 fix for reverse P/Invoke marshalling of structs. #28117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Jan 7, 2021
AaronRobinsonMSFT
added
the
Servicing-consider
jeffschwMSFT
removed
the
Servicing-consider
|
Closing due to no direct customer impact at present. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#45637
.NET 5 PR dotnet/runtime#32034. This fix represents a minor and supported change in the mentioned PR.
Customer impact
Customer reported issue dotnet/runtime#45637.
Regression?
Yes, introduced in 3.0 with the reconciling of marshalling logic.
Testing
I have verified the user's scenario. This fix has been in .NET 5 for about a year and doesn't exhibit the failing behavior.
Risk
Medium. This area is sensitive and even though the code has been in .NET 5 there is a possible culmination of other non-obvious changes that could be missing - this is speculation based on experience in the marshalling area. @jkoritzinsky or @davidwrighton may be able to provide a more accurate risk assessment.
/cc @jkoritzinsky @davidwrighton @elinor-fung