Enable pri0 crossgen build/tests per-commit, and pri1 by trigger phrase #3705
Conversation
|
@gkhanna79 @mmitche PTAL |
|
@dotnet-bot test CI please |
| if (doCrossgen) { | ||
| assert (os == 'Windows_NT' || os in Constants.crosslist) | ||
| //Add push triggers for all Checked x64 pri0 crossgen builds | ||
| if (configuration == 'Checked' && architecture == 'x64' && scenario == 'default') { |
There was a problem hiding this comment.
For X64, we should do this for Checked and Release. I noticed that we have Windows x86 CI jobs as well. Can we please enable for them too?
|
@wtgodbe Seeing some abnormal slowdowns right now so it may take a bit. I may need to take the CI server down and do some investigation later. |
|
It may be better to do this as two new scenarios (pri1crossgen) and pri0crossgen, rather than adding more flags that change behavior. |
| if (doCrossgen) { | ||
| assert (os == 'Windows_NT' || os in Constants.crosslist) | ||
| // Add trigger phrase for Checked x64 pri1 Crossgen builds | ||
| if (configuration == 'Checked' && architecture == 'x64' && scenario == 'pri1') { |
There was a problem hiding this comment.
See above for the "Checked" condition.
Also, is Pri1 run enabled for per commit or would need to be invoked via phrase?
There was a problem hiding this comment.
Checked and Release, got it. No problem.
For Pri1, it would be invoked via phrase - "test {os} pri1 r2r please.", where os can be Ubuntu, OSX, Windows_NT, or CentOS7.1
|
@dotnet-bot test CI please |
|
@mmitche PTAL (refactored according to your suggestion) |
|
I ended up restarting it, so give it a few minutes to warm up. From: William Godbe [mailto:notifications@github.com] @dotnet-bothttps://github.com/dotnet-bot test CI please — |
| break | ||
| case 'pri1r2r': | ||
| //pri1 r2r gets a push trigger for checked/release | ||
| if (architecture == 'x64' || architecture == 'x86') { |
There was a problem hiding this comment.
We should only check for x86 for Windows only, for now.
There was a problem hiding this comment.
@gkhanna79 so you only want per-commit jobs for x86, not x64?
There was a problem hiding this comment.
We want for both. I was simply saying that for x86, per-commit should only happen for Windows OS and not any other OS.
There was a problem hiding this comment.
Ah, I see. I'll make the change.
|
@gkhanna79 I changed x86 per-commit jobs to Windows-only, and switched "skiptestbuild" to "skiptests". Anything else? |
|
LGTM |
|
@dotnet-bot test CI please |
|
CI is green, merging. |
Enable pri0 crossgen build/tests per-commit, and pri1 by trigger phrase
Enable pri0 crossgen build/tests per-commit, and pri1 by trigger phrase Commit migrated from dotnet/coreclr@e90350c
This enables Checked x64 Pri0 r2r build & test jobs to be run on Windows, OSX, Ubuntu, and CentOS, per-commit. It also allows the same for pri1, by using a trigger phrase. The phrases are listed below:
x64 architectures:
Where:
os can be 'Windows_NT', 'OSX', 'Ubuntu', or 'CentOS7.1'
configuration can be 'Checked' or 'Release'
scenario can be 'r2r' (runs pri0 r2r tests) or 'pri1r2r' (runs pri1)
x86 architectures:
with the same options as above.