Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Fix up final FPU-registers for FreeBSD x86_64. #734

Merged
merged 1 commit into from
Apr 17, 2015

Conversation

josteink
Copy link
Member

FreeBSD now builds without compilation errors. For FreeBSD and glory!

                ,        ,
               /(        )`
               \ \___   / |
               /- _  `-/  '
              (/\/ \ \   /\
              / /   | `    \
              O O   ) /    |
              `-^--'`<     '
             (_.)  _  )   /
              `.___/`    /
                `-----' /
   <----.     __ / __   \
   <----|====O)))==) \) /====
   <----'    `--' `.__,' \
                |        |
                 \       /       /\
            ______( (_  / \______/
          ,'  ,-----'   |
          `--{__________)

This closes https://github.com/dotnet/coreclr/issues/594#issuecomment-93995183

FreeBSD now builds without compilation errors. For FreeBSD and glory!

                ,        ,
               /(        )`
               \ \___   / |
               /- _  `-/  '
              (/\/ \ \   /\
              / /   | `    \
              O O   ) /    |
              `-^--'`<     '
             (_.)  _  )   /
              `.___/`    /
                `-----' /
   <----.     __ / __   \
   <----|====O)))==) \) /====
   <----'    `--' `.__,' \
                |        |
                 \       /       /\
            ______( (_  / \______/
          ,'  ,-----'   |
          `--{__________)

This closes https://github.com/dotnet/coreclr/issues/594#issuecomment-93995183
@MattWhilden
Copy link

Glorious!

@richlander looks like were closer to needing freebsd CI.

@josteink
Copy link
Member Author

@MattWhilden Just to be intellectually honest: There are build-errors, but all errors related to compilation now seems eliminated.

With linking almost reaching 100% as well, I still think it's fair to call it a milestone though :)

@janvorli
Copy link
Member

LGTM

1 similar comment
@kangaroo
Copy link

LGTM

@MattWhilden
Copy link

Sure. Just making sure to have all the pieces in place.

jkotas added a commit that referenced this pull request Apr 17, 2015
Fix up final FPU-registers for FreeBSD x86_64.
@jkotas jkotas merged commit f93ab86 into dotnet:master Apr 17, 2015
@josteink josteink deleted the freebsd-fpregs branch April 17, 2015 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
os-freebsd FreeBSD OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coreclr has missing FPREG entries causing the build to fail on FreeBSD
6 participants