Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Exclude jithelp.asm for x86/Linux #8393

Merged
merged 1 commit into from
Nov 30, 2016
Merged

[x86/Linux] Exclude jithelp.asm for x86/Linux #8393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/vm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,6 @@ elseif(CLR_CMAKE_TARGET_ARCH_I386)
)

set(VM_SOURCES_WKS_ARCH
${ARCH_SOURCES_DIR}/jithelp.asm
${ARCH_SOURCES_DIR}/jitinterfacex86.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .asm file is still needed for windows x86.

Copy link
Author

@parjong parjong Nov 30, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jithelp.asm is already included in VM_SOURCES_WKS_ARCH_ASM at line 340:

334 elseif(CLR_CMAKE_TARGET_ARCH_I386)
335     set(VM_SOURCES_WKS_ARCH_ASM
336         ${ARCH_SOURCES_DIR}/RedirectedHandledJITCase.asm
337         ${ARCH_SOURCES_DIR}/asmhelpers.asm
338         ${ARCH_SOURCES_DIR}/fptext.asm
339         ${ARCH_SOURCES_DIR}/gmsasm.asm
340         ${ARCH_SOURCES_DIR}/jithelp.asm
341     )

VM_SOURCES_WKS_ARCH seems to be a list of C/C++ source files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I am sorry, I've missed that.

${ARCH_SOURCES_DIR}/profiler.cpp
)
Expand Down