This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Port 'FaultingExceptionFrame::UpdateRegDisplay' #8993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\CC @seanshpark |
|
@janvorli The following tests failed with this PR (You could see full log here)
Is it possible that this PR affects x64/Windows port?, or are there any known issues related with these tests? |
|
@dotnet-bot test Windows_NT x64 Debug Build and Test please |
|
@parjong no, the change code is purely x86 code and it is not used on other architectures. But I have checked the recent test jobs and I can see that few semi-random tests in the Windows NT run fail intermittently, so it is probably the case here. |
|
@janvorli Thank you for confirm! |
|
@dotnet-bot test Windows_NT x64 Debug Build and Test please |
sergign60
pushed a commit
to sergign60/coreclr
that referenced
this pull request
Jan 19, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a part of #8981, but seems to be necessary to enable x86/Linux exception handling.