[ARM/CI] Add manual triggering CI for arm and armel #9853

hqueue · 2017-02-28T13:07:47Z

Add following manual triggering CI for arm and armel.
This will be used with a new arm32 CI script (#9445) which is already applied to CoreFx(dotnet/corefx#16378) and Core-Setup (dotnet/core-setup#1512).

Ubuntu arm Cross Release Build (Existing but not working for a year and never used recently.)
Ubuntu arm Cross Debug Build (Existing but not working for a year and never used recently.)
Ubuntu16.04 arm Cross Release Build
Ubuntu16.04 arm Cross Debug Build
Tizen armel Cross Release Build
Tizen armel Cross Debug Build

Currently there are two default CI for ARM cross using ARM emulator which will be disabled after enabling new arm32 CI.

Linux ARM Emulator Cross Release Build
Linux ARM Emulator Cross Debug Build

After merging this PR, new arm32 CI script in #9445 will be tested with new commands.

Related issues:
https://github.com/dotnet/core-setup/issues/790
https://github.com/dotnet/core-setup/issues/725

hqueue · 2017-02-28T13:09:15Z

@dotnet-bot test ci please

hqueue · 2017-02-28T13:14:00Z

@dotnet-bot test ci please

hqueue · 2017-02-28T13:22:44Z

@dotnet-bot test ci please

hqueue · 2017-02-28T13:36:43Z

@dotnet-bot test ci please

hqueue · 2017-02-28T13:41:10Z

@dotnet-bot test ci please

hqueue · 2017-02-28T13:50:06Z

@dotnet-bot test ci please

hqueue · 2017-02-28T13:54:24Z

@dotnet-bot test ci please

hqueue · 2017-02-28T14:02:03Z

@dotnet-bot test ci please

hqueue · 2017-02-28T14:08:28Z

@dotnet-bot test ci please

hqueue · 2017-02-28T14:08:40Z

@dotnet-bot test ci please

hqueue · 2017-02-28T14:24:56Z

I've ran test ci please and result can be found at https://ci.dot.net/job/dotnet_coreclr/job/master/job/GenPRTest/job/generator_prtest/107/.

Among the generated jobs, I think following jobs are added or changed by this PR.

00:02:08.104     GeneratedJob{name='arm_cross_checked_ubuntu'}
00:02:08.104     GeneratedJob{name='arm_cross_checked_ubuntu16.04'}
00:02:08.104     GeneratedJob{name='arm_cross_checked_ubuntu16.04_prtest'}
00:02:08.104     GeneratedJob{name='arm_cross_checked_ubuntu_prtest'}
00:02:08.104     GeneratedJob{name='arm_cross_debug_ubuntu'}
00:02:08.104     GeneratedJob{name='arm_cross_debug_ubuntu16.04'}
00:02:08.104     GeneratedJob{name='arm_cross_debug_ubuntu16.04_prtest'}
00:02:08.104     GeneratedJob{name='arm_cross_debug_ubuntu_prtest'}

00:02:08.104     GeneratedJob{name='arm_cross_release_ubuntu'}
00:02:08.104     GeneratedJob{name='arm_cross_release_ubuntu16.04'}
00:02:08.104     GeneratedJob{name='arm_cross_release_ubuntu16.04_prtest'}
00:02:08.104     GeneratedJob{name='arm_cross_release_ubuntu_prtest'}

00:02:08.104     GeneratedJob{name='armel_cross_checked_tizen'}
00:02:08.104     GeneratedJob{name='armel_cross_checked_tizen_prtest'}
00:02:08.104     GeneratedJob{name='armel_cross_debug_tizen'}
00:02:08.104     GeneratedJob{name='armel_cross_debug_tizen_prtest'}
00:02:08.104     GeneratedJob{name='armel_cross_release_tizen'}
00:02:08.104     GeneratedJob{name='armel_cross_release_tizen_prtest'}

@gkhanna79 I'm looking for someone who can review and test this changes to prevent a accidental change which might cause break existing CI. Can you invite someone who can look into this?

gkhanna79 · 2017-02-28T17:16:57Z

@mmitche Can you PTAL?

mmitche

Looks good except for the couple questions

mmitche · 2017-02-28T18:13:35Z

netci.groovy

+ Utilities.getFolderName(branch)
+
+ // Copy the Windows test binaries and the Corefx build binaries
+ copyArtifacts(WindowTestsName) {


This doesn't look quite right. Is this trying to copy corefx binaries from latest?

I'm trying to copy (1) test binary and (2) corefx binary from the latest to prepare coreclr test.

Because I don't know well about relation between coreclr CI and corefx CI, I just followed a way of current CI for arm and other architectures.
https://github.com/dotnet/coreclr/blob/master/netci.groovy#L2505-L2516 (for arm)
https://github.com/dotnet/coreclr/blob/master/netci.groovy#L2884-L2900 (for other)

If this is not a right way, please let me know how to fetch correct banries of corefx and test to prepare testing.

If comments is misleading I will update the comments.

Okay I think that's right

mmitche · 2017-02-28T18:13:52Z

netci.groovy

+ arm_abi='armel'
+ corefx_os='tizen'
+ }
+ copyArtifacts("${corefxFolder}/${corefx_os}_${arm_abi}_cross_${lowerConfiguration}") {


Or is this the intended corefx copy.

Addressed above :)

I think you have it all correct except there is no checked configuration of corefx (only debug and reease). So you might want to copy from the release version in the checked and release coreclr cases, and from the debug version in the debug coreclr case

Oops, I almost missed it.
Thank you for the feedback and I've updated this as you suggested :)

gkhanna79 · 2017-03-02T18:26:28Z

Is this ready for merge?

hqueue · 2017-03-03T04:53:01Z

I'm ready and waiing for @mmitche, since he has some questions which I've answered.

mmitche · 2017-03-03T16:29:29Z

@dotnet-bot test ci please (one final check, but otherwise looks good)

hqueue · 2017-03-06T04:37:36Z

@dotnet-bot test ci please

hqueue · 2017-03-06T04:41:47Z

@dotnet-bot test ci please

Add follwoing manual triggering CI for arm and armel. This will be used by new arm32 CI script which is already applied to Core-Setup and CoreFX. Ubuntu arm Cross Release Build Ubuntu arm Cross Debug Build Ubuntu16.04 arm Cross Release Build Ubuntu16.04 arm Cross Debug Build Tizen arm Cross Release Build Tizen arm Cross Debug Build Currently there are two default CI for ARM cross using ARM emulator which will be disabled after enabling new arm32 CI. Linux ARM Emulator Cross Release Build Linux ARM Emulator Cross Debug Build Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>

hqueue · 2017-03-06T07:18:38Z

@dotnet-bot test ci please

hqueue · 2017-03-06T10:55:30Z

@mmitche I've update the PR by applying your feedback and I think it's ready for merge.

hqueue · 2017-03-09T10:36:02Z

@gkhanna79 @mmitche Can you please take a look again ? It's ready for merge and I can test new arm CI #9445 after this PR is merged. Thanks.

hqueue · 2017-03-13T07:23:17Z

@gkhanna79 @mmitche I don't want to be impatient, but I'm curious when this will be merged.

dnfclas added the cla-already-signed label Feb 28, 2017

hqueue force-pushed the arm/ci_legs branch from 2736984 to 763c40a Compare February 28, 2017 13:13

hqueue force-pushed the arm/ci_legs branch 2 times, most recently from 0512a53 to 1bd2c8a Compare February 28, 2017 13:22

hqueue force-pushed the arm/ci_legs branch from 1bd2c8a to b3f2179 Compare February 28, 2017 13:36

hqueue force-pushed the arm/ci_legs branch from b3f2179 to b22566e Compare February 28, 2017 13:49

hqueue force-pushed the arm/ci_legs branch from b22566e to 5141ec7 Compare February 28, 2017 13:52

hqueue force-pushed the arm/ci_legs branch from 5141ec7 to d2631aa Compare February 28, 2017 14:00

hqueue force-pushed the arm/ci_legs branch from d2631aa to bea8faf Compare February 28, 2017 14:08

hqueue changed the title ~~[ARM/CI][WIP] Add manual triggering CI for arm and armel~~ [ARM/CI] Add manual triggering CI for arm and armel Feb 28, 2017

mmitche reviewed Feb 28, 2017

View reviewed changes

hqueue mentioned this pull request Mar 1, 2017

[ARM/CI] ARM CI script for arm and armel #9445

Merged

hqueue force-pushed the arm/ci_legs branch from bea8faf to df9fe0d Compare March 6, 2017 04:37

hqueue force-pushed the arm/ci_legs branch from df9fe0d to ba627f0 Compare March 6, 2017 04:41

hqueue force-pushed the arm/ci_legs branch from ba627f0 to ae9c27c Compare March 6, 2017 07:18

gkhanna79 approved these changes Mar 14, 2017

View reviewed changes

gkhanna79 merged commit 50cae4e into dotnet:master Mar 14, 2017

karelz modified the milestone: 2.0.0 Aug 28, 2017

hqueue mentioned this pull request Jan 31, 2020

[ARM32/Linux] Enabling new ARM CI dotnet/runtime#7632

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ARM/CI] Add manual triggering CI for arm and armel #9853

[ARM/CI] Add manual triggering CI for arm and armel #9853

hqueue commented Feb 28, 2017 •

edited

Loading

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

gkhanna79 commented Feb 28, 2017

mmitche left a comment

mmitche Feb 28, 2017

hqueue Mar 1, 2017 •

edited

Loading

hqueue Mar 2, 2017

mmitche Mar 3, 2017

mmitche Feb 28, 2017

hqueue Mar 1, 2017

mmitche Mar 3, 2017

hqueue Mar 6, 2017

gkhanna79 commented Mar 2, 2017

hqueue commented Mar 3, 2017 •

edited

Loading

mmitche commented Mar 3, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 9, 2017

hqueue commented Mar 13, 2017

[ARM/CI] Add manual triggering CI for arm and armel #9853

[ARM/CI] Add manual triggering CI for arm and armel #9853

Conversation

hqueue commented Feb 28, 2017 • edited Loading

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

hqueue commented Feb 28, 2017

gkhanna79 commented Feb 28, 2017

mmitche left a comment

Choose a reason for hiding this comment

mmitche Feb 28, 2017

Choose a reason for hiding this comment

hqueue Mar 1, 2017 • edited Loading

Choose a reason for hiding this comment

hqueue Mar 2, 2017

Choose a reason for hiding this comment

mmitche Mar 3, 2017

Choose a reason for hiding this comment

mmitche Feb 28, 2017

Choose a reason for hiding this comment

hqueue Mar 1, 2017

Choose a reason for hiding this comment

mmitche Mar 3, 2017

Choose a reason for hiding this comment

hqueue Mar 6, 2017

Choose a reason for hiding this comment

gkhanna79 commented Mar 2, 2017

hqueue commented Mar 3, 2017 • edited Loading

mmitche commented Mar 3, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 6, 2017

hqueue commented Mar 9, 2017

hqueue commented Mar 13, 2017

hqueue commented Feb 28, 2017 •

edited

Loading

hqueue Mar 1, 2017 •

edited

Loading

hqueue commented Mar 3, 2017 •

edited

Loading