Add exception message per code review feedback

This is the same exception message used by ReadOnlyCollection<T>.
dotnet · Jan 29, 2015 · 4104077 · 4104077
1 parent 1f003a4
commit 4104077
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 36 deletions.
diff --git a/src/System.Text.RegularExpressions/src/Resources/Strings.Designer.cs b/src/System.Text.RegularExpressions/src/Resources/Strings.Designer.cs
diff --git a/src/System.Text.RegularExpressions/src/Resources/Strings.resx b/src/System.Text.RegularExpressions/src/Resources/Strings.resx
@@ -186,6 +186,9 @@
   <data name="NotEnoughParens" xml:space="preserve">
     <value>Not enough )'s.</value>
   </data>
+  <data name="NotSupported_ReadOnlyCollection" xml:space="preserve">
+    <value>Collection is read-only.</value>
+  </data>
   <data name="OnlyAllowedOnce" xml:space="preserve">
     <value>This operation is only allowed once per object.</value>
   </data>

diff --git a/...stem.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCaptureCollection.cs b/...stem.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCaptureCollection.cs
@@ -139,28 +139,28 @@ int IList<Capture>.IndexOf(Capture item)
 
         void IList<Capture>.Insert(int index, Capture item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList<Capture>.RemoveAt(int index)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         Capture IList<Capture>.this[int index]
         {
             get { return this[index]; }
-            set { throw new NotSupportedException(); }
+            set { throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection); }
         }
 
         void ICollection<Capture>.Add(Capture item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void ICollection<Capture>.Clear()
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool ICollection<Capture>.Contains(Capture item)
@@ -186,17 +186,17 @@ bool ICollection<Capture>.IsReadOnly
 
         bool ICollection<Capture>.Remove(Capture item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         int IList.Add(object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList.Clear()
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool IList.Contains(object value)
@@ -211,7 +211,7 @@ int IList.IndexOf(object value)
 
         void IList.Insert(int index, object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool IList.IsFixedSize
@@ -226,18 +226,18 @@ bool IList.IsReadOnly
 
         void IList.Remove(object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList.RemoveAt(int index)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         object IList.this[int index]
         {
             get { return this[index]; }
-            set { throw new NotSupportedException(); }
+            set { throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection); }
         }
     }
 

diff --git a/...System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexGroupCollection.cs b/...System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexGroupCollection.cs
@@ -170,28 +170,28 @@ int IList<Group>.IndexOf(Group item)
 
         void IList<Group>.Insert(int index, Group item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList<Group>.RemoveAt(int index)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         Group IList<Group>.this[int index]
         {
             get { return this[index]; }
-            set { throw new NotSupportedException(); }
+            set { throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection); }
         }
 
         void ICollection<Group>.Add(Group item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void ICollection<Group>.Clear()
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool ICollection<Group>.Contains(Group item)
@@ -217,17 +217,17 @@ bool ICollection<Group>.IsReadOnly
 
         bool ICollection<Group>.Remove(Group item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         int IList.Add(object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList.Clear()
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool IList.Contains(object value)
@@ -242,7 +242,7 @@ int IList.IndexOf(object value)
 
         void IList.Insert(int index, object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool IList.IsFixedSize
@@ -257,18 +257,18 @@ bool IList.IsReadOnly
 
         void IList.Remove(object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList.RemoveAt(int index)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         object IList.this[int index]
         {
             get { return this[index]; }
-            set { throw new NotSupportedException(); }
+            set { throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection); }
         }
     }
 

diff --git a/...System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexMatchCollection.cs b/...System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexMatchCollection.cs
@@ -171,28 +171,28 @@ int IList<Match>.IndexOf(Match item)
 
         void IList<Match>.Insert(int index, Match item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList<Match>.RemoveAt(int index)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         Match IList<Match>.this[int index]
         {
             get { return this[index]; }
-            set { throw new NotSupportedException(); }
+            set { throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection); }
         }
 
         void ICollection<Match>.Add(Match item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void ICollection<Match>.Clear()
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool ICollection<Match>.Contains(Match item)
@@ -218,17 +218,17 @@ bool ICollection<Match>.IsReadOnly
 
         bool ICollection<Match>.Remove(Match item)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         int IList.Add(object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList.Clear()
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool IList.Contains(object value)
@@ -243,7 +243,7 @@ int IList.IndexOf(object value)
 
         void IList.Insert(int index, object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         bool IList.IsFixedSize
@@ -258,18 +258,18 @@ bool IList.IsReadOnly
 
         void IList.Remove(object value)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         void IList.RemoveAt(int index)
         {
-            throw new NotSupportedException();
+            throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection);
         }
 
         object IList.this[int index]
         {
             get { return this[index]; }
-            set { throw new NotSupportedException(); }
+            set { throw new NotSupportedException(SR.NotSupported_ReadOnlyCollection); }
         }
     }